svx/uiconfig/ui/inspectortextpanel.ui | 15 ++++++++ vcl/inc/jsdialog/enabled.hxx | 3 + vcl/jsdialog/enabled.cxx | 61 +++++++++++++++++++++++----------- vcl/source/window/builder.cxx | 3 + 4 files changed, 62 insertions(+), 20 deletions(-)
New commits: commit bccb60764b8c5aeb9f8f77eb5545831c3f29f1af Author: Caolán McNamara <[email protected]> AuthorDate: Mon Mar 2 14:45:07 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Mar 2 21:13:54 2026 +0100 adapt sidebar coverage report for calc Change-Id: Idf43604da494481667688a4a7670cc11f1bbe689 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200841 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/vcl/inc/jsdialog/enabled.hxx b/vcl/inc/jsdialog/enabled.hxx index 7122c4215945..b095881e1d5b 100644 --- a/vcl/inc/jsdialog/enabled.hxx +++ b/vcl/inc/jsdialog/enabled.hxx @@ -39,7 +39,8 @@ std::vector<OUString> completeCommonDialogList(const o3tl::sorted_vector<OUStrin /*LibreOfficeKitDocumentType*/ int docType, bool linguisticDataAvailable); // returns vector of common/shared sidebar .ui files not seen that should be seen to have complete coverage -std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUString>& entries); +std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUString>& entries, + /*LibreOfficeKitDocumentType*/ int docType); } /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */ diff --git a/vcl/jsdialog/enabled.cxx b/vcl/jsdialog/enabled.cxx index fb5ad669bcf3..0d35a7480664 100644 --- a/vcl/jsdialog/enabled.cxx +++ b/vcl/jsdialog/enabled.cxx @@ -690,6 +690,10 @@ std::vector<OUString> completeCalcSidebarList(const o3tl::sorted_vector<OUString std::vector<OUString> missing; for (const auto& entry : SidebarList) { + // Skip this one for now, it can only be seen in certain xlsx documents + if (entry == u"modules/scalc/ui/sidebardatabase.ui") + continue; + OUString sEntry(entry); if (sEntry.startsWith("modules/scalc/") && !entries.contains(sEntry)) missing.push_back(sEntry); @@ -697,7 +701,8 @@ std::vector<OUString> completeCalcSidebarList(const o3tl::sorted_vector<OUString return missing; } -std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUString>& entries) +std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUString>& entries, + /*LibreOfficeKitDocumentType*/ int docType) { std::vector<OUString> missing; for (const auto& entry : SidebarList) @@ -722,26 +727,46 @@ std::vector<OUString> completeCommonSidebarList(const o3tl::sorted_vector<OUStri // Skip this one, theme related, disabled at the moment else if (entry == u"modules/schart/ui/sidebartheme.ui") continue; - // Skip this one, in practice it appears in draw/impress - // TODO: it should probably be made to appear in writer too - else if (entry == u"svx/ui/mediaplayback.ui") - continue; // Skip this one, I don't think it can appear in practice else if (entry == u"svx/ui/sidebargallery.ui") continue; - // Skip this one, its context means it cannot appear in writer - else if (entry == u"svx/ui/sidebarshadow.ui") - continue; - // Skip this one, its context means it cannot appear in writer - else if (entry == u"svx/ui/sidebartexteffect.ui") - continue; - // Skip this one, its context means it cannot appear in writer - else if (entry == u"svx/ui/sidebarlists.ui") - continue; - // Skip this one, its context means it can only appear in draw/impress - else if (entry == u"svx/ui/defaultshapespanel.ui") - continue; - else if (!entries.contains(sEntry)) + + if (docType != LOK_DOCTYPE_TEXT) + { + // These only appear in writer + if (entry == u"svx/ui/accessibilitycheckentry.ui" || + entry == u"svx/ui/accessibilitychecklevel.ui" || + entry == u"svx/ui/inspectortextpanel.ui") + { + continue; + } + } + + if (docType == LOK_DOCTYPE_TEXT) + { + // Skip this one, its context means it cannot appear in writer + if (entry == u"svx/ui/sidebarshadow.ui") + continue; + // Skip this one, its context means it cannot appear in writer + else if (entry == u"svx/ui/sidebartexteffect.ui") + continue; + } + + if (docType != LOK_DOCTYPE_PRESENTATION && docType != LOK_DOCTYPE_DRAWING) + { + // Skip this one, in practice it appears in draw/impress + // TODO: it should probably be made to appear in writer/calc too + if (entry == u"svx/ui/mediaplayback.ui") + continue; + // Skip this one, its context means it can only appear in draw/impress + else if (entry == u"svx/ui/defaultshapespanel.ui") + continue; + // Skip this one, its context means it can only appear in draw/impress + else if (entry == u"svx/ui/sidebarlists.ui") + continue; + } + + if (!entries.contains(sEntry)) missing.push_back(sEntry); } return missing; diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx index acc23034ef6f..2646055cf60c 100644 --- a/vcl/source/window/builder.cxx +++ b/vcl/source/window/builder.cxx @@ -254,7 +254,8 @@ void Application::UICoverageReport(tools::JsonWriter& rJson, rJson.putSimpleValue(entry); } - std::vector<OUString> missingCommonSidebarUIs = jsdialog::completeCommonSidebarList(entries); + std::vector<OUString> missingCommonSidebarUIs = jsdialog::completeCommonSidebarList(entries, + docType); rJson.put("CompleteCommonSidebarCoverage", missingCommonSidebarUIs.empty()); if (!missingCommonSidebarUIs.empty()) { commit e66a4ed5bc6d71e9a080432a0a5cb581fdc6416d Author: Caolán McNamara <[email protected]> AuthorDate: Mon Mar 2 16:40:55 2026 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Mar 2 21:13:44 2026 +0100 add a11y names to the inspector text panel Change-Id: I85c880e5ecb769cf73401264dc485e96ebb140bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/svx/uiconfig/ui/inspectortextpanel.ui b/svx/uiconfig/ui/inspectortextpanel.ui index bf957e1c80de..a31968c510f3 100644 --- a/svx/uiconfig/ui/inspectortextpanel.ui +++ b/svx/uiconfig/ui/inspectortextpanel.ui @@ -118,6 +118,11 @@ <property name="visible">True</property> <property name="tooltip-text" translatable="yes" context="paragraph_style_toggle_btn|tooltip_text">Paragraph Styles</property> <property name="use-underline">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="paragraphstyles-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="inspectortextpanel|paragraphstyles-atkobject">Paragraph Styles</property> + </object> + </child> </object> <packing> <property name="expand">False</property> @@ -129,6 +134,11 @@ <property name="visible">True</property> <property name="tooltip-text" translatable="yes" context="character_style_toggle_btn|tooltip_text">Character Styles</property> <property name="use-underline">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="characterstyles-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="inspectortextpanel|characterstyles-atkobject">Character Styles</property> + </object> + </child> </object> <packing> <property name="expand">False</property> @@ -140,6 +150,11 @@ <property name="visible">True</property> <property name="tooltip-text" translatable="yes" context="direct_formatting_toggle_btn|tooltip_text">Direct Formatting</property> <property name="use-underline">True</property> + <child internal-child="accessible"> + <object class="AtkObject" id="directformatting-atkobject"> + <property name="AtkObject::accessible-name" translatable="yes" context="inspectortextpanel|directformatting-atkobject">Direct Formatting</property> + </object> + </child> </object> <packing> <property name="expand">False</property>
