sw/source/filter/ww8/docxattributeoutput.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b6359a0913f52288f99c8f6bce3f232c088885e2
Author:     Justin Luth <[email protected]>
AuthorDate: Fri Feb 27 09:06:40 2026 -0500
Commit:     Justin Luth <[email protected]>
CommitDate: Fri Feb 27 23:34:50 2026 +0100

    NFC cleanup: remove newly added assert that doesn't make sense
    
    As vmiklos pointed out,
    a few lines earlier just proved that it exists
    (m_pRedlineData.back() would have crashed if size 0)
    so this assert is not doing what I imagined.
    
    StartRun pushes a redlineData.
    EndRun pops the redlineData.
    
    The idea behind the assert was to ensure that we can't get
    EndRuns without StartRuns.
    So nice as a confirmation during development
    (although as we've seen also pointless in this particular case)
    but definitely not something to leave in as
    a permanent reminder that I am not a real programmer.
    
    Change-Id: Iefd2a8ae9cfce634d7908daec0569672b7d11252
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/200634
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <[email protected]>

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index febe11d813ac..8b6554c83128 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2235,7 +2235,7 @@ void DocxAttributeOutput::EndRun(const SwTextNode* pNode, 
sal_Int32 nPos, sal_In
     {
         EndRedline(m_pRedlineData.back());
     }
-    assert(m_pRedlineData.size());
+
     m_pRedlineData.pop_back();
 
     DoWriteBookmarksStart(m_rFinalBookmarksStart);

Reply via email to