cui/uiconfig/ui/imagetabpage.ui |   45 +++++++++++++++++++---------------------
 1 file changed, 22 insertions(+), 23 deletions(-)

New commits:
commit b0c1f3188ba2adb62a549cd51c629c4e5be6cc72
Author:     Parth Raiyani <[email protected]>
AuthorDate: Sat Nov 22 14:05:58 2025 +0530
Commit:     Szymon Kłos <[email protected]>
CommitDate: Tue Dec 30 13:00:18 2025 +0100

    accessibility: replace GtkBox with GtkFrame for tiling offset section
    
    Use GtkFrame so the “Tiling Offset” label becomes a group label, and ensure 
the inner GtkComboBoxText and GtkSpinButton have proper accessible names
    
    Signed-off-by: Parth Raiyani <[email protected]>
    Change-Id: I1654a9c4633334ed019fe39a8d14161197d0f5a3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194351
    Reviewed-by: Szymon Kłos <[email protected]>
    Tested-by: Jenkins CollaboraOffice <[email protected]>

diff --git a/cui/uiconfig/ui/imagetabpage.ui b/cui/uiconfig/ui/imagetabpage.ui
index 87c950f48e2b..57d79c2cff75 100644
--- a/cui/uiconfig/ui/imagetabpage.ui
+++ b/cui/uiconfig/ui/imagetabpage.ui
@@ -476,30 +476,17 @@
               </packing>
             </child>
             <child>
-              <object class="GtkBox" id="tileoffbox">
+              <object class="GtkFrame" id="tileoffbox">
                 <property name="visible">True</property>
                 <property name="can-focus">False</property>
-                <property name="orientation">vertical</property>
-                <property name="spacing">3</property>
-                <child>
-                  <object class="GtkLabel" id="label15">
-                    <property name="visible">True</property>
-                    <property name="can-focus">False</property>
-                    <property name="label" translatable="yes" 
context="imagetabpage|label15">Tiling Offset:</property>
-                    <property name="use-underline">True</property>
-                    <property name="mnemonic-widget">tileofflb</property>
-                    <property name="xalign">0</property>
-                  </object>
-                  <packing>
-                    <property name="expand">False</property>
-                    <property name="fill">True</property>
-                    <property name="position">0</property>
-                  </packing>
-                </child>
+                <property name="label-xalign">0</property>
+                <property name="shadow-type">none</property>
                 <child>
                   <object class="GtkBox" id="box13">
                     <property name="visible">True</property>
                     <property name="can-focus">False</property>
+                    <property name="margin-start">12</property>
+                    <property name="margin-top">6</property>
                     <property name="spacing">6</property>
                     <child>
                       <object class="GtkComboBoxText" id="tileofflb">
@@ -511,6 +498,11 @@
                           <item translatable="yes" 
context="imagetabpage|tileofflb">Row</item>
                           <item translatable="yes" 
context="imagetabpage|tileofflb">Column</item>
                         </items>
+                        <child internal-child="accessible">
+                          <object class="AtkObject" id="tileofflb-atkobject">
+                            <property name="AtkObject::accessible-name" 
translatable="yes" context="imagetabpage|tileofflb">Tiling Offset 
Type</property>
+                          </object>
+                        </child>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -525,6 +517,11 @@
                         <property name="hexpand">True</property>
                         <property name="truncate-multiline">True</property>
                         <property name="adjustment">adjustment1</property>
+                        <child internal-child="accessible">
+                          <object class="AtkObject" id="tileoffmtr-atkobject">
+                            <property name="AtkObject::accessible-name" 
translatable="yes" context="imagetabpage|tileoffmtr">Tiling Offset 
Value</property>
+                          </object>
+                        </child>
                       </object>
                       <packing>
                         <property name="expand">False</property>
@@ -533,11 +530,13 @@
                       </packing>
                     </child>
                   </object>
-                  <packing>
-                    <property name="expand">False</property>
-                    <property name="fill">True</property>
-                    <property name="position">1</property>
-                  </packing>
+                </child>
+                <child type="label">
+                  <object class="GtkLabel" id="label15">
+                    <property name="visible">True</property>
+                    <property name="can-focus">False</property>
+                    <property name="label" translatable="yes" 
context="imagetabpage|label15">Tiling Offset:</property>
+                  </object>
                 </child>
               </object>
               <packing>

Reply via email to