cui/source/dialogs/SpellDialog.cxx | 2 +- editeng/source/misc/svxacorr.cxx | 2 +- svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 2 +- svx/source/svdraw/svdedtv1.cxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
New commits: commit 06d1b0b203c45532035070f145a855f64b355802 Author: Noel Grandin <[email protected]> AuthorDate: Tue Dec 9 09:41:13 2025 +0200 Commit: Xisco Fauli <[email protected]> CommitDate: Thu Dec 11 09:30:46 2025 +0100 ubsan: fix downcast (2) svx/source/svdraw/svdedtv1.cxx:1011:56: runtime error: downcast of address 0x7bd2deeea930 which does not point to an object of type 'const SfxUInt16Item' 0x7bd2deeea930: note: object is of type 'XFillTransparenceItem' 00 00 00 00 90 ee bd 84 a2 7b 00 00 00 00 00 00 fb 03 be be 17 02 00 00 89 be 00 00 00 00 00 00 ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'XFillTransparenceItem' after commit 953219b81126f5c092bf5375c0abe2a7afce40d2 Author: Noel Grandin <[email protected]> Date: Wed Dec 3 21:34:19 2025 +0200 make XFillTransparenceItem extend SfxPoolItem Change-Id: Id29305cf0a7b7431207aaa7f8ede639f035a630e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195276 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> (cherry picked from commit bd84bd35e9a64638d7434ef00e4b75f71da7ebfd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195295 Reviewed-by: Xisco Fauli <[email protected]> diff --git a/svx/source/svdraw/svdedtv1.cxx b/svx/source/svdraw/svdedtv1.cxx index ef9c36668a72..94bfea69508a 100644 --- a/svx/source/svdraw/svdedtv1.cxx +++ b/svx/source/svdraw/svdedtv1.cxx @@ -1008,7 +1008,7 @@ void SdrEditView::MergeAttrFromMarked(SfxItemSet& rAttr, bool bOnlyHardAttr) con const SfxPoolItem* pItem = rSet.GetItem(XATTR_FILLTRANSPARENCE); if (pItem) { - sal_uInt16 nTransparency = static_cast<const SfxUInt16Item*>(pItem)->GetValue(); + sal_uInt16 nTransparency = static_cast<const XFillTransparenceItem*>(pItem)->GetValue(); sPayload = OUString::number(nTransparency); sPayload = ".uno:FillTransparence=" + sPayload; commit 66740b23a11571d4ba39d0bd9f1d06ca1ce57082 Author: Caolán McNamara <[email protected]> AuthorDate: Sat Dec 6 11:57:46 2025 +0000 Commit: Xisco Fauli <[email protected]> CommitDate: Thu Dec 11 09:30:38 2025 +0100 cid#1557959 Variable copied when it could be moved and cid#1660011 Variable copied when it could be moved cid#1660458 Variable copied when it could be moved Change-Id: I1073f7d1af6d8055353b5f36e30cf81cafac3fad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> (cherry picked from commit 42de271b199ac6ef7c5d0bf98ec9f85fb97f4a59) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195296 Reviewed-by: Xisco Fauli <[email protected]> diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx index 59ce2fc5c1b1..381612ebf2e6 100644 --- a/cui/source/dialogs/SpellDialog.cxx +++ b/cui/source/dialogs/SpellDialog.cxx @@ -2120,7 +2120,7 @@ svx::SpellPortions SentenceEditWindow_Impl::CreateSpellPortions() const { aPortion1.bIgnoreThisError = true; } - aRet.push_back(aPortion1); + aRet.push_back(std::move(aPortion1)); nStart = aStart->nPosition; eLang = aStart->eLanguage; ++aStart; diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 6bfc0898cfea..510277fae19d 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -2060,7 +2060,7 @@ SvxAutoCorrect::SearchWordsInList( auto pRet = lcl_SearchWordsInList( &rList, rTxt, rStt, nEndPos ); if( pRet ) { - rLang = aLanguageTag; + rLang = std::move(aLanguageTag); return pRet; } } diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx index 34b985b13ea0..be5884188cb5 100644 --- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx +++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx @@ -413,7 +413,7 @@ static void GetTextAreaOutline( FWCharacterData aCharacterData; if ( pVirDev->GetTextOutlines( aCharacterData.vOutlines, rText, 0, 0, -1, nWidth, aDXArray ) ) { - rParagraph.vCharacters.push_back( aCharacterData ); + rParagraph.vCharacters.push_back(std::move(aCharacterData)); } else {
