filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu | 2 +- filter/source/config/fragments/types/MS_PowerPoint_2007_XML_AutoPlay.xcu | 2 +- filter/source/config/fragments/types/MS_PowerPoint_2007_XML_Template.xcu | 2 +- filter/source/config/fragments/types/calc_OOXML.xcu | 2 +- filter/source/config/fragments/types/calc_OOXML_Template.xcu | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
New commits: commit ccd8ecd780a6951e181f62b6097937b286af3056 Author: Justin Luth <[email protected]> AuthorDate: Sat Nov 29 14:32:45 2025 -0500 Commit: Xisco Fauli <[email protected]> CommitDate: Wed Dec 10 14:18:59 2025 +0100 tdf#165180 xlsx convert-to: prefer Excel 2010–365 Spreadsheet, not 2007 The context here is running a command-line soffice --convert-to xlsx myfile.ods which MIGHT (perhaps in Windows) create a 1st edition ECMA 2007 XLSX instead of a modern Excel 2010+ XLSX. Filtercache registers valid conversion types in a seemingly random order but if it's a "Preferred" one - set it to the front of the list. // Of course multiple "Preferred" registrations can occur // (they shouldn't - but they can!) ... For XLSX, neither MS_Excel_2007_XML nor calc_OOXML said that they were the preferred one, so it is somewhat ambiguous about which one will win. // first item is guaranteed as "preferred" one! [The difference between the PPTX case and this one is that BOTH pptx filters said they were preferred, so the last one processed (inserted at front) won. In this case, NEITHER xlsx filter says it is preferred so the first one processed (push_back) won.] Note that this does not make it the preferred UI choice... Note also that on Linux at least (where I am writing/testing this) it also does not make any difference since the order was {"Office Open XML Spreadsheet", "MS Excel 2007 XML"} Thus no unit test. Change-Id: I496568de9bdda1753010d5438e4858139937a49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195025 Tested-by: Jenkins Reviewed-by: Justin Luth <[email protected]> Signed-off-by: Xisco Fauli <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195256 diff --git a/filter/source/config/fragments/types/calc_OOXML.xcu b/filter/source/config/fragments/types/calc_OOXML.xcu index 5b17c1c1db3a..8868951571e9 100644 --- a/filter/source/config/fragments/types/calc_OOXML.xcu +++ b/filter/source/config/fragments/types/calc_OOXML.xcu @@ -20,7 +20,7 @@ <prop oor:name="URLPattern"/> <prop oor:name="Extensions"><value>xlsx xlsm</value></prop> <prop oor:name="MediaType"><value>application/vnd.openxmlformats-officedocument.spreadsheetml.sheet</value></prop> - <prop oor:name="Preferred"><value>false</value></prop> + <prop oor:name="Preferred"><value>true</value></prop> <prop oor:name="PreferredFilter"><value>Calc Office Open XML</value></prop> <prop oor:name="UIName"><value xml:lang="en-US">Office Open XML Spreadsheet</value></prop> <prop oor:name="ClipboardFormat"/> diff --git a/filter/source/config/fragments/types/calc_OOXML_Template.xcu b/filter/source/config/fragments/types/calc_OOXML_Template.xcu index 677762fa78f7..e7865779781a 100644 --- a/filter/source/config/fragments/types/calc_OOXML_Template.xcu +++ b/filter/source/config/fragments/types/calc_OOXML_Template.xcu @@ -20,7 +20,7 @@ <prop oor:name="URLPattern"/> <prop oor:name="Extensions"><value>xltx xltm</value></prop> <prop oor:name="MediaType"><value>application/vnd.openxmlformats-officedocument.spreadsheetml.template</value></prop> - <prop oor:name="Preferred"><value>false</value></prop> + <prop oor:name="Preferred"><value>true</value></prop> <prop oor:name="PreferredFilter"><value>Calc Office Open XML Template</value></prop> <prop oor:name="UIName"><value xml:lang="en-US">Office Open XML Spreadsheet Template</value></prop> <prop oor:name="ClipboardFormat"/> commit 9fd371c914ab6f52415a1db0a4dc5df7e2f00dc5 Author: Justin Luth <[email protected]> AuthorDate: Mon Dec 1 15:44:22 2025 -0500 Commit: Xisco Fauli <[email protected]> CommitDate: Wed Dec 10 14:18:47 2025 +0100 tdf#165180 pptx convert-to: prefer PP 2010–365 Presentation, not 2007 The context here is running a command-line soffice --convert-to pptx myfile.odp which MIGHT (perhaps in Windows) create a 1st edition ECMA 2007 PPTX instead of a modern PowerPoint 2010+ PPTX. Filtercache registers valid conversion types in a seemingly random order but if it's a "Preferred" one - set it to the front of the list. // Of course multiple "Preferred" registrations can occur // (they shouldn't - but they can!) ... For PPTX, both filters said they were the preferred one so it is somewhat ambiguous about which one will win. // first item is guaranteed as "preferred" one! Note that this does not make it the preferred UI choice... Also note that on Linux at least (where I am writing/testing this) it also does not make any difference since the order was {"MS PowerPoint 2007 XML", "Office Open XML Presentation"} and since both got 'inserted' into the front, the last one (the 2010 filter) won. Thus no unit test. Change-Id: I94a391ff9d4f3be4215019260e9190ca1610878d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195024 Tested-by: Jenkins Reviewed-by: Justin Luth <[email protected]> Signed-off-by: Xisco Fauli <[email protected]> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195255 diff --git a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu index 75b9f95d46cd..c0db257fbad0 100644 --- a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu +++ b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML.xcu @@ -20,7 +20,7 @@ <prop oor:name="URLPattern"/> <prop oor:name="Extensions"><value>pptx</value></prop> <prop oor:name="MediaType"><value>application/vnd.openxmlformats-officedocument.presentationml.presentation</value></prop> - <prop oor:name="Preferred"><value>true</value></prop> + <prop oor:name="Preferred"><value>false</value></prop> <prop oor:name="PreferredFilter"><value>Impress MS PowerPoint 2007 XML</value></prop> <prop oor:name="UIName"><value xml:lang="en-US">PowerPoint 2007–365</value></prop> <prop oor:name="ClipboardFormat"/> diff --git a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_AutoPlay.xcu b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_AutoPlay.xcu index 7c8dc62e24e6..de2714abdf4a 100644 --- a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_AutoPlay.xcu +++ b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_AutoPlay.xcu @@ -20,7 +20,7 @@ <prop oor:name="URLPattern"/> <prop oor:name="Extensions"><value>ppsx</value></prop> <prop oor:name="MediaType"><value>application/vnd.openxmlformats-officedocument.presentationml.slideshow</value></prop> - <prop oor:name="Preferred"><value>true</value></prop> + <prop oor:name="Preferred"><value>false</value></prop> <prop oor:name="PreferredFilter"><value>Impress MS PowerPoint 2007 XML AutoPlay</value></prop> <prop oor:name="UIName"><value xml:lang="en-US">PowerPoint 2007–365</value></prop> <prop oor:name="ClipboardFormat"/> diff --git a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_Template.xcu b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_Template.xcu index c64c11276053..4714ebd47971 100644 --- a/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_Template.xcu +++ b/filter/source/config/fragments/types/MS_PowerPoint_2007_XML_Template.xcu @@ -20,7 +20,7 @@ <prop oor:name="URLPattern"/> <prop oor:name="Extensions"><value>potx potm</value></prop> <prop oor:name="MediaType"><value>application/vnd.openxmlformats-officedocument.presentationml.template</value></prop> - <prop oor:name="Preferred"><value>true</value></prop> + <prop oor:name="Preferred"><value>false</value></prop> <prop oor:name="PreferredFilter"><value>Impress MS PowerPoint 2007 XML Template</value></prop> <prop oor:name="UIName"><value xml:lang="en-US">PowerPoint 2007–365 Template</value></prop> <prop oor:name="ClipboardFormat"/>
