sw/qa/extras/ooxmlexport/ooxmlexport10.cxx | 31 ++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-)
New commits: commit 99790494233f3d92738219380b2ef4fd4eddd2bc Author: Xisco Fauli <[email protected]> AuthorDate: Fri Nov 21 14:22:12 2025 +0100 Commit: Xisco Fauli <[email protected]> CommitDate: Fri Nov 21 20:58:44 2025 +0100 sw_ooxmlexport10: do not skip DOCX export validation Change-Id: Ie233edf7cd2ca501feb4f0879dbd2ca92ddbcab4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/194329 Reviewed-by: Xisco Fauli <[email protected]> Tested-by: Jenkins diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx index 3db2a5c07d95..51532b3cb6d8 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport10.cxx @@ -40,11 +40,14 @@ class Test : public SwModelTestBase { public: - Test() : SwModelTestBase(u"/sw/qa/extras/ooxmlexport/data/"_ustr, /*bSkipValidation*/ true) {} + Test() : SwModelTestBase(u"/sw/qa/extras/ooxmlexport/data/"_ustr) {} }; DECLARE_OOXMLEXPORT_TEST(testWPGtextboxes, "testWPGtextboxes.docx") { + // FIXME: validation error in OOXML export: Errors: 1 + skipValidation(); + CPPUNIT_ASSERT_EQUAL(2, getShapes()); auto MyShape = getShape(1); @@ -166,6 +169,9 @@ CPPUNIT_TEST_FIXTURE(Test, testFloattableNestedCellStartDOCXExport) DECLARE_OOXMLEXPORT_TEST(testWpgOnly, "wpg-only.docx") { + // FIXME: validation error in OOXML export: Errors: 1 + skipValidation(); + uno::Reference<drawing::XShape> xShape = getShape(1); // Check position, it was nearly 0. This is a shape, so use getPosition(), not a property. CPPUNIT_ASSERT_EQUAL(oox::drawingml::convertEmuToHmm(548005), xShape->getPosition().X); @@ -570,6 +576,9 @@ DECLARE_OOXMLEXPORT_TEST(testDMLGroupShapeRunFonts, "dml-groupshape-runfonts.doc DECLARE_OOXMLEXPORT_TEST(testStrict, "strict.docx") { + // FIXME: validation error in OOXML export: Errors: 4 + skipValidation(); + uno::Reference<beans::XPropertySet> xPageStyle(getStyles(u"PageStyles"_ustr)->getByName(u"Standard"_ustr), uno::UNO_QUERY); // This was only 127, pt suffix was ignored, so this got parsed as twips instead of points. CPPUNIT_ASSERT_EQUAL(sal_Int32(convertTwipToMm100(72 * 20)), getProperty<sal_Int32>(xPageStyle, u"BottomMargin"_ustr)); @@ -621,6 +630,10 @@ CPPUNIT_TEST_FIXTURE(Test, testSmartartStrict) }; createSwDoc("strict-smartart.docx"); verify(); + + // FIXME: validation error in OOXML export: Errors: 4 + skipValidation(); + saveAndReload(TestFilter::DOCX); verify(); } @@ -666,6 +679,9 @@ DECLARE_OOXMLEXPORT_TEST(testLargeTwips, "large-twips.docx" ) DECLARE_OOXMLEXPORT_TEST(testNegativeCellMarginTwips, "negative-cell-margin-twips.docx") { + // FIXME: validation error in OOXML export: Errors: 4 + skipValidation(); + // Slightly related to cp#1000043, the twips value was negative, which wrapped around somewhere, // while MSO seems to ignore that as well. xmlDocUniquePtr pXmlDoc = parseLayoutDump(); @@ -675,6 +691,9 @@ DECLARE_OOXMLEXPORT_TEST(testNegativeCellMarginTwips, "negative-cell-margin-twip DECLARE_OOXMLEXPORT_TEST(testFdo38414, "fdo38414.docx") { + // FIXME: validation error in OOXML export: Errors: 2 + skipValidation(); + // The cells in the last (4th) column were merged properly and so the result didn't have the same height. // (Since w:gridBefore is worked around by faking another cell in the row, so column count is thus 5 // instead of 4, therefore compare height of cells 4 and 5 rather than 3 and 4.) @@ -741,6 +760,10 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf116194) CPPUNIT_TEST_FIXTURE(Test, testTdf134606) { createSwDoc("tdf134606.docx"); + + // FIXME: validation error in OOXML export: Errors: 1 + skipValidation(); + save(TestFilter::DOCX); // The problem was that the importer lost the nested table structure with w:gridBefore xmlDocUniquePtr pXmlDoc = parseExport(u"word/document.xml"_ustr); @@ -772,6 +795,9 @@ DECLARE_OOXMLEXPORT_TEST(testChartSize, "chart-size.docx") DECLARE_OOXMLEXPORT_TEST(testInlineGroupshape, "inline-groupshape.docx") { + // FIXME: validation error in OOXML export: Errors: 1 + skipValidation(); + // Inline groupshape was in the background, so it was hidden sometimes by other shapes. CPPUNIT_ASSERT_EQUAL(true, getProperty<bool>(getShape(1), u"Opaque"_ustr)); } @@ -801,6 +827,9 @@ DECLARE_OOXMLEXPORT_TEST(testCaption, "caption.docx") DECLARE_OOXMLEXPORT_TEST(testGroupshapeTrackedchanges, "groupshape-trackedchanges.docx") { + // FIXME: validation error in OOXML export: Errors: 1 + skipValidation(); + uno::Reference<drawing::XShapes> xGroup(getShape(1), uno::UNO_QUERY); uno::Reference<drawing::XShape> xShape(xGroup->getByIndex(0), uno::UNO_QUERY); // Shape text was completely missing, ensure inserted text is available.
