Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1675020: Performance inefficiencies (PASS_BY_VALUE)
/canvas/source/opengl/ogl_canvashelper.cxx: 631 in
oglcanvas::CanvasHelper::fillTexturedPolyPolygon(const
com::sun::star::rendering::XCanvas *, const
com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &,
const com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, const
com::sun::star::uno::Sequence<com::sun::star::rendering::Texture>
&)::[lambda(const oglcanvas::CanvasHelper&, const basegfx::B2DHomMatrix &,
unsigned int, unsigned int, const com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) (instance 2)]::operator ()(const oglcanvas::CanvasHelper&, const
basegfx::B2DHomMatrix &, unsigned int, unsigned int, const
com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) const()
_____________________________________________________________________________________________
*** CID 1675020: Performance inefficiencies (PASS_BY_VALUE)
/canvas/source/opengl/ogl_canvashelper.cxx: 631 in
oglcanvas::CanvasHelper::fillTexturedPolyPolygon(const
com::sun::star::rendering::XCanvas *, const
com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &,
const com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, const
com::sun::star::uno::Sequence<com::sun::star::rendering::Texture>
&)::[lambda(const oglcanvas::CanvasHelper&, const basegfx::B2DHomMatrix &,
unsigned int, unsigned int, const com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) (instance 2)]::operator ()(const oglcanvas::CanvasHelper&, const
basegfx::B2DHomMatrix &, unsigned int, unsigned int, const
com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) const()
625 // force-convert color to ARGB8888 int color
space
626 uno::Sequence<sal_Int8> aARGBBytes(
627
aLayout.ColorSpace->convertToIntegerColorSpace(
628 aPixelData,
629 canvastools::getStdColorSpace()));
630
>>> CID 1675020: Performance inefficiencies (PASS_BY_VALUE)
>>> Capturing variable "aTexture" of type
>>> "com::sun::star::rendering::Texture" (size 136 bytes) by value, which
>>> exceeds the low threshold of 128 bytes.
631 rAct.maFunction = [aTexture = textures[0],
632 aPixelSize = aSize,
633 aPixelData = aARGBBytes,
634 nPixelCrc32 = rtl_crc32(0,
aARGBBytes.getConstArray(), aARGBBytes.getLength())]
635 (const CanvasHelper& rHelper,
636 const basegfx::B2DHomMatrix& rTransform,
** CID 1675019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
_____________________________________________________________________________________________
*** CID 1675019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/canvas/source/opengl/ogl_canvashelper.cxx: 575 in
oglcanvas::CanvasHelper::fillTexturedPolyPolygon(const
com::sun::star::rendering::XCanvas *, const
com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &,
const com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, const
com::sun::star::uno::Sequence<com::sun::star::rendering::Texture> &)()
569 {
570 // copy state from Gradient polypoly locally
571 // (given object might change!)
572 const ::canvas::ParametricPolyPolygon::Values
aValues(
573 pGradient->getValues() );
574
>>> CID 1675019: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aValues" is passed-by-value as parameter to
>>> "canvas::ParametricPolyPolygon::Values::Values(canvas::ParametricPolyPolygon::Values
>>> const &) /*implicit =default*/", when it could be moved instead.
575 rAct.maFunction = [aValues = aValues, aTexture =
textures[0]]
576 (const CanvasHelper& rHelper,
577 const basegfx::B2DHomMatrix& rTransform,
578 GLenum eSrcBlend,
579 GLenum eDstBlend,
580 const rendering::ARGBColor& /*rColor*/,
** CID 1675018: Performance inefficiencies (PASS_BY_VALUE)
/canvas/source/opengl/ogl_canvashelper.cxx: 575 in
oglcanvas::CanvasHelper::fillTexturedPolyPolygon(const
com::sun::star::rendering::XCanvas *, const
com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &,
const com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, const
com::sun::star::uno::Sequence<com::sun::star::rendering::Texture>
&)::[lambda(const oglcanvas::CanvasHelper&, const basegfx::B2DHomMatrix &,
unsigned int, unsigned int, const com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) (instance 1)]::operator ()(const oglcanvas::CanvasHelper&, const
basegfx::B2DHomMatrix &, unsigned int, unsigned int, const
com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) const()
_____________________________________________________________________________________________
*** CID 1675018: Performance inefficiencies (PASS_BY_VALUE)
/canvas/source/opengl/ogl_canvashelper.cxx: 575 in
oglcanvas::CanvasHelper::fillTexturedPolyPolygon(const
com::sun::star::rendering::XCanvas *, const
com::sun::star::uno::Reference<com::sun::star::rendering::XPolyPolygon2D> &,
const com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, const
com::sun::star::uno::Sequence<com::sun::star::rendering::Texture>
&)::[lambda(const oglcanvas::CanvasHelper&, const basegfx::B2DHomMatrix &,
unsigned int, unsigned int, const com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) (instance 1)]::operator ()(const oglcanvas::CanvasHelper&, const
basegfx::B2DHomMatrix &, unsigned int, unsigned int, const
com::sun::star::rendering::ARGBColor &, const
std::vector<basegfx::B2DPolyPolygon, std::allocator<basegfx::B2DPolyPolygon>>
&) const()
569 {
570 // copy state from Gradient polypoly locally
571 // (given object might change!)
572 const ::canvas::ParametricPolyPolygon::Values
aValues(
573 pGradient->getValues() );
574
>>> CID 1675018: Performance inefficiencies (PASS_BY_VALUE)
>>> Capturing variable "aTexture" of type
>>> "com::sun::star::rendering::Texture" (size 136 bytes) by value, which
>>> exceeds the low threshold of 128 bytes.
575 rAct.maFunction = [aValues = aValues, aTexture =
textures[0]]
576 (const CanvasHelper& rHelper,
577 const basegfx::B2DHomMatrix& rTransform,
578 GLenum eSrcBlend,
579 GLenum eDstBlend,
580 const rendering::ARGBColor& /*rColor*/,
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
