sw/source/ui/misc/bookmark.cxx | 5 +++++ 1 file changed, 5 insertions(+)
New commits: commit 7648e7f164efd31404431834d1ef1d89500d5882 Author: Skyler Grey <[email protected]> AuthorDate: Thu Jun 26 15:12:47 2025 +0000 Commit: Szymon Kłos <[email protected]> CommitDate: Tue Nov 18 10:52:00 2025 +0100 fix: hide edit bookmark button in LOK While we've added a way to edit text in treeview items, this button isn't hooked up to use it. Therefore, we should hide it to avoid user confusion Signed-off-by: Skyler Grey <[email protected]> Change-Id: Ic8cc49a6c8cb7212fc7f6793f76a5fee89e05d35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187194 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Szymon Kłos <[email protected]> (cherry picked from commit ae62dbba4d75880940af5febea3c5a62843a661e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193850 Tested-by: Jenkins diff --git a/sw/source/ui/misc/bookmark.cxx b/sw/source/ui/misc/bookmark.cxx index b6fed596c2bb..69a7c57af1d5 100644 --- a/sw/source/ui/misc/bookmark.cxx +++ b/sw/source/ui/misc/bookmark.cxx @@ -17,6 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include <comphelper/lok.hxx> #include <rtl/ustrbuf.hxx> #include <sfx2/request.hxx> #include <svl/stritem.hxx> @@ -407,6 +408,10 @@ SwInsertBookmarkDlg::SwInsertBookmarkDlg(weld::Window* pParent, SwWrtShell& rS, m_xEditTextBtn->set_sensitive(false); m_xRenameBtn->set_sensitive(false); + // Clicking the "edit text" button is not yet supported in JSDialog + // to edit this we need to send back 'editend' events from editing via another trigger - presumably double-clicking + m_xEditTextBtn->set_visible(!comphelper::LibreOfficeKit::isActive()); + // select 3rd column, otherwise it'll pick 1st one m_xBookmarksBox->set_column_editables({ false, false, true, false, false });
