android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java | 4 +- android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java | 14 ++++------ 2 files changed, 8 insertions(+), 10 deletions(-)
New commits: commit 8c5ebf9d80d16f5d7571894ec3fb7df0bddb4faf Author: Michael Weghorn <[email protected]> AuthorDate: Tue Nov 11 13:38:35 2025 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Wed Nov 12 01:41:52 2025 +0100 android: Make 2 DocumentOverlayView members final Change-Id: I549df56a7f5696172cbca0f489765b638f0d493c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193802 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Jenkins diff --git a/android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java b/android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java index 086108cd903f..a247e2ec41ec 100644 --- a/android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java +++ b/android/source/src/java/org/libreoffice/overlay/DocumentOverlayView.java @@ -48,8 +48,8 @@ public class DocumentOverlayView extends View implements View.OnTouchListener { private boolean mInitialized = false; private List<RectF> mSelections = new ArrayList<RectF>(); - private List<RectF> mScaledSelections = new ArrayList<RectF>(); - private Paint mSelectionPaint = new Paint(); + private final List<RectF> mScaledSelections = new ArrayList<RectF>(); + private final Paint mSelectionPaint = new Paint(); private boolean mSelectionsVisible; private GraphicSelection mGraphicSelection; commit c73174c3e74c0423ff8721c2d77a2e366d713a01 Author: Michael Weghorn <[email protected]> AuthorDate: Tue Nov 11 13:32:27 2025 +0100 Commit: Michael Weghorn <[email protected]> CommitDate: Wed Nov 12 01:41:41 2025 +0100 android: Drop unnecessary size check before iterating No need to avoid iterating over an empty array list. Change-Id: I59e4062f63ed0990478f564c15920c99e2ee8ee2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193801 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java b/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java index aeb555a5a48c..173d8e25b0db 100644 --- a/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java +++ b/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java @@ -418,16 +418,14 @@ public class LayerRenderer implements GLSurfaceView.Renderer { public void drawForeground() { /* Draw any extra layers that were added (likely plugins) */ - if (mExtraLayers.size() > 0) { - for (Layer layer : mExtraLayers) { - if (!layer.usesDefaultProgram()) - deactivateDefaultProgram(); + for (Layer layer : mExtraLayers) { + if (!layer.usesDefaultProgram()) + deactivateDefaultProgram(); - layer.draw(mPageContext); + layer.draw(mPageContext); - if (!layer.usesDefaultProgram()) - activateDefaultProgram(); - } + if (!layer.usesDefaultProgram()) + activateDefaultProgram(); } /* Draw the vertical scrollbar. */
