dbaccess/source/ui/control/RelationControl.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
New commits: commit 72c0183416bc18147cd6728eca9ea00f7d2cc050 Author: Neil Roberts <[email protected]> AuthorDate: Sun Nov 9 14:38:20 2025 +0100 Commit: Noel Grandin <[email protected]> CommitDate: Tue Nov 11 06:46:08 2025 +0100 Fix selecting other table when inserting relation with only 2 tables In the dialog to insert a new relation, if there are only two tables the list box to select the two tables tries to react to one of the selected tables changing by making the other list box choose the other table. However it was doing this by making the other list box flip its selection. This breaks if the dialog is reacting to the user reselecting the same table in a list box because the other list box flips its value even though the value in the first list box hasn’t actually changed. To fix the problem this patch makes it explicitly use the opposite table from the first list box instead of just flipping its value. Change-Id: Ibf5d39de9406c4617c33c8f81a8605cb61811f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193760 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/dbaccess/source/ui/control/RelationControl.cxx b/dbaccess/source/ui/control/RelationControl.cxx index 4856b0c3b188..289c25b8af23 100644 --- a/dbaccess/source/ui/control/RelationControl.cxx +++ b/dbaccess/source/ui/control/RelationControl.cxx @@ -524,7 +524,7 @@ namespace dbaui pOther = m_xRightTable.get(); else pOther = m_xLeftTable.get(); - pOther->set_active(1 - pOther->get_active()); + pOther->set_active(1 - rListBox.get_active()); OJoinTableView::OTableWindowMap::const_iterator aIter = m_pTableMap->begin(); OTableWindow* pFirst = aIter->second;
