On 08/01/2012 03:29 PM, Michael Meeks wrote:
That aside - I've never been a big fan of the "crash on bad input" mode
of OUString::copy() that seems incredibly lame to me. Is there any
convincing performance reason that anyone can work out for not just
returning an empty string in these cases ? ie. create a new rtl _copy
method that does the checking out-of-line in the method: I wonder how
common the case of copy() a full string is that we in-line the check for
that.
make rtl::OUString::copy(beginIndex, count) clip to [0..length)? yeah,
why not (then again, -1's sentinel nature, cf. indexOf, might mean that
silent clipping of beginIndex=-1 to beginIndex=0 is unfortunate)
Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
