sw/qa/uitest/writer_tests2/formatBulletsNumbering.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
New commits: commit fede6f817fefd6528a25c1f0f69e06aebe07d9d5 Author: Neil Roberts <[email protected]> AuthorDate: Wed Nov 5 19:41:03 2025 +0100 Commit: René Engelhard <[email protected]> CommitDate: Thu Nov 6 06:28:19 2025 +0100 Change the Unicode character used in the bullet point test Apparently U+107B5 isn’t in the version of Noto Sans used by Debian so the test fails for them. Seeing as it doesn’t really matter what the character is as long as it’s outside of the BMP, let’s change the test to use a character that is available in Debian to make things easier for the package maintainers. I checked whether the new character should be available by downloading the DejaVu Sans package from packages.debian.org. Change-Id: Ie0bd8d1e141ee41e84727bf7dee4f523a65ef210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193497 Tested-by: René Engelhard <[email protected]> Reviewed-by: René Engelhard <[email protected]> Tested-by: Jenkins diff --git a/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py b/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py index f6ce6b620fb8..05dbf50a7ac6 100644 --- a/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py +++ b/sw/qa/uitest/writer_tests2/formatBulletsNumbering.py @@ -307,9 +307,9 @@ class formatBulletsNumbering(UITestCase): def test_bullets_and_numbering_bullet_from_smp(self): with self.ui_test.create_doc_in_start_center("writer") as xComponent: - # Change the bullet to U+107B5 MODIFIER LETTER BILABIAL CLICK. This is a character - # outside of the basic multilingual plane which means that it can’t be stored in a - # single sal_Unicode variable. Verifies tdf#166488 + # Change the bullet to U+1F431 CAT FACE. This is a character outside of the basic + # multilingual plane which means that it can’t be stored in a single sal_Unicode + # variable. Verifies tdf#166488 with self.ui_test.execute_dialog_through_command(".uno:BulletsAndNumberingDialog") as xDialog: # Select the BulletPage's selector xTabs = xDialog.getChild("tabcontrol") @@ -322,22 +322,21 @@ class formatBulletsNumbering(UITestCase): self.assertEqual(get_state_as_dict(xSelector)["SelectedItemId"], "1") xChangeBulletBtn = xBulletPage.getChild("changeBulletBtn") with self.ui_test.execute_blocking_action(xChangeBulletBtn.executeAction, args=('CLICK', ())) as xCharSetDialog: - # Select the Noto Sans font because that should contain the character + # Select the DejaVu Sans font because that should contain the character xFontName = xCharSetDialog.getChild("fontlb") - xFontName.executeAction("SET", mkPropertyValues({"TEXT": "Noto Sans"})) + xFontName.executeAction("SET", mkPropertyValues({"TEXT": "DejaVu Sans"})) # Use the hex entry to select the character xHexText = xCharSetDialog.getChild("hexvalue") - xHexText.executeAction("SET", mkPropertyValues({"TEXT": "107B5"})) + xHexText.executeAction("SET", mkPropertyValues({"TEXT": "1F431"})) # Check that the character was selected by checking the name xCharName = xCharSetDialog.getChild("charname") - self.assertEqual(get_state_as_dict(xCharName)["Text"], - "MODIFIER LETTER BILABIAL CLICK") + self.assertEqual(get_state_as_dict(xCharName)["Text"], "CAT FACE") # Check that the numbering level was updated for the paragraph in the document xDocCursor = xComponent.getText().createTextCursor() xNumberingRules = xDocCursor.getPropertyValue("NumberingRules") xNumberingLevel = xNumberingRules.getByIndex(0) self.assertEqual(convert_property_values_to_dict(xNumberingLevel)["BulletChar"], - "\U000107B5") + "\U0001F431") # vim: set shiftwidth=4 softtabstop=4 expandtab:
