solenv/bin/modules/installer/windows/feature.pm | 5 +++++ 1 file changed, 5 insertions(+)
New commits: commit d74ce83da797b695d6005651f27619eec2077f28 Author: Christian Lohmaier <[email protected]> AuthorDate: Tue Nov 4 15:34:11 2025 +0100 Commit: Adolfo Jayme Barrientos <[email protected]> CommitDate: Tue Nov 4 18:56:49 2025 +0100 tdf#164070 always install en-US UI localization on windows if en-US is not available, and the user didn't manually configure the UI language, adding another language (via means of mar updater for example) can cause that new language being used instead of the language the user had installed initially since there's no explicit default/fallback. Since any language that will be added in future is likely to not use a latin script/will be quite unfamliliar to the user, having en-US to rely on as a fallback is a much better experience. The problem occurs on systems where the selected UI language is not matching the windows language, so for new installations the user has to go to options and set the language manually. That in turn then will be an additional safeguard for further updates, since now there's a language explicitly configured and thus no reason for LO to "guess" what to use as default. Change-Id: I67dd9a9ddd9de3ce79eb9144eab06b6f10134c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193422 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <[email protected]> (cherry picked from commit 51ccb1ead1c94e695489b1c494e4bf611d8b4b5c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193426 Reviewed-by: Adolfo Jayme Barrientos <[email protected]> diff --git a/solenv/bin/modules/installer/windows/feature.pm b/solenv/bin/modules/installer/windows/feature.pm index 6dff3dead168..318e38a4ef34 100644 --- a/solenv/bin/modules/installer/windows/feature.pm +++ b/solenv/bin/modules/installer/windows/feature.pm @@ -112,6 +112,11 @@ sub get_feature_display # No program module visible. if ( $onefeature->{'gid'} eq "gid_Module_Prg" ) { $display = "0"; } + # hide en-US languagepack/always install it (unless using commandline arguments) + # mar-updater would add new languages that could be picked by default if the en-US fallback + # is not available/wasn't installed originally. (see tdf#164070) + $display = "0" if($onefeature->{'gid'} eq "gid_Module_Langpack_Root_en_US"); + # making all feature invisible in Language packs and in Help packs! if ( $installer::globals::languagepack || $installer::globals::helppack ) { $display = "0"; }
