sc/source/filter/xml/xmlexprt.cxx | 2 +- sc/source/filter/xml/xmltransformationi.cxx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
New commits: commit 4ff6d294eac41288bce19b377c0a8857b8cb4992 Author: Regina Henschel <[email protected]> AuthorDate: Fri Oct 24 00:58:41 2025 +0200 Commit: Adolfo Jayme Barrientos <[email protected]> CommitDate: Thu Oct 30 20:46:29 2025 +0100 tdf#169019 write char not number, read col from 0 Write: Separator as string not as number. Read: Column index starts at 0, although in dialog is starts at 1 I have not checked the other transformations but only ColumnSplit. Change-Id: I37812a4b575a425981ed09257263c829bd2eefc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192929 Reviewed-by: Regina Henschel <[email protected]> Tested-by: Jenkins (cherry picked from commit 48cf7f1123637be847140ef9acc49e8f5f056677) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193020 Reviewed-by: Adolfo Jayme Barrientos <[email protected]> diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 1ddf8ff1af90..1d2f86cdb4aa 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -4243,7 +4243,7 @@ void ScXMLExport::WriteExternalDataTransformations(ScDocument& rDoc, const std:: std::shared_ptr<sc::SplitColumnTransformation> aSplitTransformation = std::dynamic_pointer_cast<sc::SplitColumnTransformation>(itr); AddAttribute(XML_NAMESPACE_CALC_EXT, XML_COLUMN, OUString::number(aSplitTransformation->getColumn())); - AddAttribute(XML_NAMESPACE_CALC_EXT, XML_SEPARATOR, OUString::number(aSplitTransformation->getSeparator())); + AddAttribute(XML_NAMESPACE_CALC_EXT, XML_SEPARATOR, OUString(aSplitTransformation->getSeparator())); SvXMLElementExport aTransformation(*this, XML_NAMESPACE_CALC_EXT, XML_COLUMN_SPLIT_TRANSFORMATION, true, true); } break; diff --git a/sc/source/filter/xml/xmltransformationi.cxx b/sc/source/filter/xml/xmltransformationi.cxx index 238d4bde2a5b..2359c034ae3f 100644 --- a/sc/source/filter/xml/xmltransformationi.cxx +++ b/sc/source/filter/xml/xmltransformationi.cxx @@ -134,7 +134,7 @@ ScXMLColumnSplitContext::ScXMLColumnSplitContext( ScXMLImport& rImport, const rtl::Reference<sax_fastparser::FastAttributeList>& rAttrList) : ScXMLImportContext(rImport) { - SCCOL mnCol = 0; + SCCOL mnCol = -1; OUString cSeparator; if (rAttrList.is()) @@ -157,7 +157,7 @@ ScXMLColumnSplitContext::ScXMLColumnSplitContext( } } - if (mnCol > 0) + if (mnCol >= 0) { ScDocument* pDoc = GetScImport().GetDocument(); auto& rDataSources = pDoc->GetExternalDataMapper().getDataSources();
