basegfx/source/matrix/b3dhommatrix.cxx | 20 ------------ bin/find-can-be-private-symbols.functions.results | 2 - bin/find-mergedlib-can-be-private-symbols.functions.results | 2 - compilerplugins/clang/unusedmethods.results | 4 -- include/basegfx/matrix/b3dhommatrix.hxx | 4 -- 5 files changed, 32 deletions(-)
New commits: commit 8d6dc4541642de4998b1637ad08f4c26f418d52d Author: Caolán McNamara <[email protected]> AuthorDate: Sun Oct 26 21:43:47 2025 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Oct 27 11:00:32 2025 +0100 cid#1659813 Division or modulo by float zero in unused code, so lets just remove it Change-Id: I95b3441dd9ae2efcc5fe3d93c37f3062c1bc8edb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193008 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/basegfx/source/matrix/b3dhommatrix.cxx b/basegfx/source/matrix/b3dhommatrix.cxx index 35cac47b1822..a5e9d42343eb 100644 --- a/basegfx/source/matrix/b3dhommatrix.cxx +++ b/basegfx/source/matrix/b3dhommatrix.cxx @@ -95,26 +95,6 @@ namespace basegfx return *this; } - B3DHomMatrix& B3DHomMatrix::operator*=(double fValue) - { - const double fOne(1.0); - - if(!fTools::equal(fOne, fValue)) - mpImpl->doMulMatrix(fValue); - - return *this; - } - - B3DHomMatrix& B3DHomMatrix::operator/=(double fValue) - { - const double fOne(1.0); - - if(!fTools::equal(fOne, fValue)) - mpImpl->doMulMatrix(1.0 / fValue); - - return *this; - } - B3DHomMatrix& B3DHomMatrix::operator*=(const B3DHomMatrix& rMat) { if(rMat.isIdentity()) diff --git a/bin/find-can-be-private-symbols.functions.results b/bin/find-can-be-private-symbols.functions.results index 755f62df9469..6235f5df43fa 100644 --- a/bin/find-can-be-private-symbols.functions.results +++ b/bin/find-can-be-private-symbols.functions.results @@ -10465,10 +10465,8 @@ basegfx::B2IVector::operator*=(basegfx::B2DHomMatrix const&) basegfx::B2IVector::operator=(basegfx::B2ITuple const&) basegfx::B3DHomMatrix::determinant() const basegfx::B3DHomMatrix::isLastLineDefault() const -basegfx::B3DHomMatrix::operator*=(double) basegfx::B3DHomMatrix::operator+=(basegfx::B3DHomMatrix const&) basegfx::B3DHomMatrix::operator-=(basegfx::B3DHomMatrix const&) -basegfx::B3DHomMatrix::operator/=(double) basegfx::B3DHomMatrix::rotate(basegfx::B3DTuple const&) basegfx::B3DHomMatrix::scale(basegfx::B3DTuple const&) basegfx::B3DHomMatrix::translate(basegfx::B3DTuple const&) diff --git a/bin/find-mergedlib-can-be-private-symbols.functions.results b/bin/find-mergedlib-can-be-private-symbols.functions.results index 67e5a47fd127..9577516e6cf7 100644 --- a/bin/find-mergedlib-can-be-private-symbols.functions.results +++ b/bin/find-mergedlib-can-be-private-symbols.functions.results @@ -10942,10 +10942,8 @@ basegfx::B2IVector::operator=(basegfx::B2ITuple const&) basegfx::B3DHomMatrix::decompose(basegfx::B3DTuple&, basegfx::B3DTuple&, basegfx::B3DTuple&, basegfx::B3DTuple&) const basegfx::B3DHomMatrix::determinant() const basegfx::B3DHomMatrix::isLastLineDefault() const -basegfx::B3DHomMatrix::operator*=(double) basegfx::B3DHomMatrix::operator+=(basegfx::B3DHomMatrix const&) basegfx::B3DHomMatrix::operator-=(basegfx::B3DHomMatrix const&) -basegfx::B3DHomMatrix::operator/=(double) basegfx::B3DHomMatrix::rotate(basegfx::B3DTuple const&) basegfx::B3DHomMatrix::scale(basegfx::B3DTuple const&) basegfx::B3DHomMatrix::shearXY(double, double) diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 2745e1860df7..5b74a0e01fc9 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -308,10 +308,6 @@ include/basegfx/matrix/b3dhommatrix.hxx:97 basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator+=(const basegfx::B3DHomMatrix &) include/basegfx/matrix/b3dhommatrix.hxx:98 basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator-=(const basegfx::B3DHomMatrix &) -include/basegfx/matrix/b3dhommatrix.hxx:104 - basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator*=(double) -include/basegfx/matrix/b3dhommatrix.hxx:105 - basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator/=(double) include/basegfx/matrix/hommatrixtemplate.hxx:43 basegfx::internal::ImplMatLine::ImplMatLine<RowSize>(unsigned short) include/basegfx/matrix/hommatrixtemplate.hxx:297 diff --git a/include/basegfx/matrix/b3dhommatrix.hxx b/include/basegfx/matrix/b3dhommatrix.hxx index 773898ccf65e..2a4cb0046414 100644 --- a/include/basegfx/matrix/b3dhommatrix.hxx +++ b/include/basegfx/matrix/b3dhommatrix.hxx @@ -100,10 +100,6 @@ namespace basegfx // comparison bool operator==(const B3DHomMatrix& rMat) const; - // multiplication, division by constant value - B3DHomMatrix& operator*=(double fValue); - B3DHomMatrix& operator/=(double fValue); - // matrix multiplication (from the left) B3DHomMatrix& operator*=(const B3DHomMatrix& rMat);
