basctl/source/basicide/idedataprovider.cxx | 4 ++-- svx/source/tbxctrls/grafctrl.cxx | 4 ++-- test/source/xmltesttools.cxx | 6 +++++- 3 files changed, 9 insertions(+), 5 deletions(-)
New commits: commit 39addcea01288be21f918209255ea1fd5d1dfc21 Author: Caolán McNamara <[email protected]> AuthorDate: Mon Oct 20 09:03:40 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Oct 20 13:46:30 2025 +0200 cid#1667071 Overflowed integer argument Change-Id: Ibb141f34723e71eb7d809affee4ee9ca394d5cff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192694 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/svx/source/tbxctrls/grafctrl.cxx b/svx/source/tbxctrls/grafctrl.cxx index 87046c0f5191..6271fc33c397 100644 --- a/svx/source/tbxctrls/grafctrl.cxx +++ b/svx/source/tbxctrls/grafctrl.cxx @@ -111,10 +111,10 @@ void ImplGrafControl::ImplModify() maCommand == ".uno:GrafBlue" || maCommand == ".uno:GrafLuminance" || maCommand == ".uno:GrafContrast" ) - a <<= sal_Int16( nVal ); + a <<= sal_Int16(std::clamp<sal_Int64>(nVal, SAL_MIN_INT16, SAL_MAX_INT16)); else if ( maCommand == ".uno:GrafGamma" || maCommand == ".uno:GrafTransparence" ) - a <<= sal_Int32( nVal ); + a <<= sal_Int32(std::clamp<sal_Int64>(nVal, SAL_MIN_INT32, SAL_MAX_INT32)); if ( !a.hasValue() ) return; commit 61ce786060ee3aa376c1eddb1308ccbbb9013409 Author: Caolán McNamara <[email protected]> AuthorDate: Mon Oct 20 08:55:52 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Oct 20 13:46:23 2025 +0200 cid#1667146 Variable copied when it could be moved and cid#1667145 Variable copied when it could be moved Change-Id: I743bd3f2a3a3db35f31864b360c8fcd953522015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192693 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/basctl/source/basicide/idedataprovider.cxx b/basctl/source/basicide/idedataprovider.cxx index a8e9ac03f074..0a2f2082ec40 100644 --- a/basctl/source/basicide/idedataprovider.cxx +++ b/basctl/source/basicide/idedataprovider.cxx @@ -127,7 +127,7 @@ void ImplGetMembersOfUnoType(SymbolInfoList& rMembers, const IdeSymbolInfo& rNod auto pNode = std::make_shared<IdeSymbolInfo>( xInterface->getName(), IdeSymbolKind::UNO_INTERFACE, rNode.sIdentifier); pNode->sQualifiedName = xInterface->getName(); - rMembers.push_back(pNode); + rMembers.push_back(std::move(pNode)); } return; } @@ -344,7 +344,7 @@ void ImplGetChildrenOfBasicLibrary(SymbolInfoList& rChildren, const IdeSymbolInf pNode->sOriginLibrary = rParent.sName; pNode->sParentName = rParent.sName; pNode->sIdentifier = rParent.sIdentifier + u":" + pNode->sName; - rChildren.push_back(pNode); + rChildren.push_back(std::move(pNode)); } } } commit 1eaee7b2149a90b257ed873b75eab76fd4f087b7 Author: Caolán McNamara <[email protected]> AuthorDate: Mon Oct 20 08:55:15 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Mon Oct 20 13:46:16 2025 +0200 cid#1667257 silence unsafe_xml_parse_config Change-Id: I327a0dd57838e24ac4b4d478a70e42044ef1e0d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192692 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Caolán McNamara <[email protected]> diff --git a/test/source/xmltesttools.cxx b/test/source/xmltesttools.cxx index 45ef3fa1029d..97d4fa714f31 100644 --- a/test/source/xmltesttools.cxx +++ b/test/source/xmltesttools.cxx @@ -57,7 +57,11 @@ xmlDocUniquePtr XmlTestTools::parseXmlStream(SvStream* pStream) pBuffer[nSize] = 0; auto pCharBuffer = reinterpret_cast<xmlChar*>(pBuffer.get()); SAL_INFO("test", "XmlTestTools::parseXmlStream: pBuffer is '" << pCharBuffer << "'"); - return xmlDocUniquePtr(xmlReadDoc(pCharBuffer, nullptr, nullptr, XML_PARSE_NODICT | XML_PARSE_HUGE)); + int options = XML_PARSE_NODICT; +#if !defined(__COVERITY__) + options |= XML_PARSE_HUGE; +#endif + return xmlDocUniquePtr(xmlReadDoc(pCharBuffer, nullptr, nullptr, options)); } xmlDocUniquePtr XmlTestTools::dumpAndParse(MetafileXmlDump& rDumper, const GDIMetaFile& rGDIMetaFile)
