Hi, After some checks I've come to the conclusion that your patch does it as it should, and the breakage should be fixed in oxygen-gtk. The only problem remains is when this fix should be done (i.e. there'll be some time until your patch gets into a released version of LibO, and until then we should use current oxygen-gtk code). Any pointers on when your change may be released once pushed?
Regards, Ruslan On Sat, Jul 28, 2012 at 4:51 PM, Ivan Timofeev <timofeev....@gmail.com> wrote: > Hi Ruslan, > > > On 28.07.2012 15:08, Ruslan Kabatsayev wrote: >> >> This mostly looks good, but breaks a bit border for oxygen-gtk > > > I have just installed it, yeah - it is broken... :( > > >> (which somehow has worked before the patch, unlike other themes). > > > Strange. > > >> I'd suggest using getFrameWidth() to adjust the shadow rect. > > > AFAICS vcl makes listbox a child of borderwindow, which receives the border > sizes via DecorationView::DrawFrame: > http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1212 > (for oxygen-gtk it is 2 for each border); > > shrinks the listbox size by that border in Resize(): > http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#2066 > > draws CTRL_LISTBOX PART_WINDOW (i.e. calls gtk_paint_shadow with > "scrolled_window") with its size (i.e. client+borders): > http://opengrok.libreoffice.org/xref/core/vcl/source/window/brdwin.cxx#1362 > > Try to build with my patch and the attached diff applied, IMHO LibO will do > things right. But probably I missed something (as usual :). > > >> OTOH, we've done quite some customizations in oxygen-gtk before to >> make it look better with LibO, so maybe this is what should be changed >> on oxygen-gtk side. > > > It would be great if you could check it. :) > > Regards, > Ivan _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
