cui/source/dialogs/AdditionsDialog.cxx | 8 ++++---- cui/source/inc/AdditionsDialog.hxx | 1 - 2 files changed, 4 insertions(+), 5 deletions(-)
New commits: commit 2c3569eb319f2fa398118789ee6d2bc116175aae Author: Michael Weghorn <[email protected]> AuthorDate: Tue Oct 7 08:56:07 2025 +0200 Commit: Michael Weghorn <[email protected]> CommitDate: Tue Oct 7 10:25:51 2025 +0200 additions dialog: Replace AdditionsDialog::m_sTag with local var It's only used in the ctor, so doesn't need to be a class member. Change-Id: I7ccc9c77d74c8d5b663906fbb25833a735bc1c91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192002 Tested-by: Jenkins Reviewed-by: Michael Weghorn <[email protected]> diff --git a/cui/source/dialogs/AdditionsDialog.cxx b/cui/source/dialogs/AdditionsDialog.cxx index 3d943262679c..e395ee48d84b 100644 --- a/cui/source/dialogs/AdditionsDialog.cxx +++ b/cui/source/dialogs/AdditionsDialog.cxx @@ -447,12 +447,12 @@ AdditionsDialog::AdditionsDialog(weld::Window* pParent, const OUString& sAdditio m_xButtonShowMore->connect_clicked(LINK(this, AdditionsDialog, ShowMoreHdl)); m_xButtonClose->connect_clicked(LINK(this, AdditionsDialog, CloseButtonHdl)); - m_sTag = sAdditionsTag; m_nMaxItemCount = PAGE_SIZE; // Dialog initialization item count m_nCurrentListItemCount = 0; // First, there is no item on the list. + OUString sTag = sAdditionsTag; OUString titlePrefix = CuiResId(RID_CUISTR_ADDITIONS_DIALOG_TITLE_PREFIX); - if (!m_sTag.isEmpty()) + if (!sTag.isEmpty()) { // tdf#142564 localize extension category names OUString sDialogTitle = u""_ustr; if (sAdditionsTag == "Templates") @@ -484,10 +484,10 @@ AdditionsDialog::AdditionsDialog(weld::Window* pParent, const OUString& sAdditio else { set_title(titlePrefix); - m_sTag = "allextensions"; // Means empty parameter + sTag = "allextensions"; // Means empty parameter } - OUString sEncodedURLPart = INetURLObject::encode(m_sTag, INetURLObject::PART_PCHAR, + OUString sEncodedURLPart = INetURLObject::encode(sTag, INetURLObject::PART_PCHAR, INetURLObject::EncodeMechanism::All); //FIXME: Temporary URL - v0 is not using actual api diff --git a/cui/source/inc/AdditionsDialog.hxx b/cui/source/inc/AdditionsDialog.hxx index 2f60b9a7a8cb..b9eeab110e50 100644 --- a/cui/source/inc/AdditionsDialog.hxx +++ b/cui/source/inc/AdditionsDialog.hxx @@ -81,7 +81,6 @@ public: ::rtl::Reference<SearchAndParseThread> m_pSearchThread; OUString m_sURL; - OUString m_sTag; size_t m_nMaxItemCount; // Max number of item which will appear on the list before the press to the show more button. size_t m_nCurrentListItemCount; // Current number of item on the list
