vcl/source/accessibility/accessiblelistbox.cxx | 3 ---
1 file changed, 3 deletions(-)
New commits:
commit 4e9b160f0e0353bb367dac466e85c26faaebcae7
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Jul 22 09:44:43 2025 +0200
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Jul 22 10:51:59 2025 +0200
a11y: Drop obsolete comment about "Solution" for listbox entry parent
This is obsolete. The parent is no longer passed as null since
commit 77ea0535271d3fb3d49c8d916ecf80e0a7f70653
Date: Wed Sep 18 15:54:23 2019 +0200
accessibility: fix leak of AccessibleListBoxEntry
The problem is that AccessibleListBoxEntry from the Stylist in the
sidebar are not deleted until the document is closed, which causes
slowdowns because it causes an ever-growing list of window
listeners.
There are several issues here:
* AccessibleListBoxEntry::m_aParent appears of dubious merit because
SvTreeList::Move may move entries to a different parent;
this member may or may not be initialised depending on where
the instance is created; there are confusing comments mentioning a
"Solution" but not the corresponding problem; just remove it and
let
it do a dynamic lookup when needed
[...]
Change-Id: Ic0a464e7040ddae135a1f68f629b5aa7aa3881f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188139
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/vcl/source/accessibility/accessiblelistbox.cxx
b/vcl/source/accessibility/accessiblelistbox.cxx
index a79fd49b5fdd..496720662e60 100644
--- a/vcl/source/accessibility/accessiblelistbox.cxx
+++ b/vcl/source/accessibility/accessiblelistbox.cxx
@@ -431,9 +431,6 @@ Reference< XAccessible > SAL_CALL
AccessibleListBox::getSelectedAccessibleChild(
if ( nSelCount == ( nSelectedChildIndex + 1 ) )
{
- // Solution: Set the parameter of the parent to null to let entry
determine the parent by itself
- //xChild = new AccessibleListBoxEntry( *getListBox(), pEntry, this
);
- //xChild = new AccessibleListBoxEntry( *getListBox(), pEntry,
nullptr );
xChild = implGetAccessible(*pEntry).get();
break;
}
