sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx | 13 ------------- 1 file changed, 13 deletions(-)
New commits: commit d73330a77fbf0b5d975d713fb28cac2a7be39495 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Thu Jun 12 18:23:27 2025 +0200 Commit: Noel Grandin <noelgran...@gmail.com> CommitDate: Fri Jun 13 09:39:39 2025 +0200 tdf#166968 A11Y sidebar hides direct formatting issues after PDF export Revert "prevent accessibility check from locking up the UI" This reverts commit e081e03342ca8c262403bd9febdc01151a2935be. Since it seems to cause problems. Change-Id: I278e51260bc921ff14ab6474a12bedf073ddc3dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx index 62d8f19252c9..4faf99d307f1 100644 --- a/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx +++ b/sw/source/uibase/sidebar/A11yCheckIssuesPanel.cxx @@ -154,12 +154,6 @@ void AccessibilityCheckLevel::addEntryForGroup( std::shared_ptr<sfx::AccessibilityIssue> const& pIssue) { auto nGroupIndex = size_t(eGroup); - // prevent the UI locking up forever, this is effectively an O(n^2) situation, given the way the UI additions work - if (m_aEntries[nGroupIndex].size() > 500) - { - SAL_WARN("sw", "too many a11y issues, not adding to panel"); - return; - } auto xEntry = std::make_unique<AccessibilityCheckEntry>(m_xBoxes[nGroupIndex].get(), pIssue); m_xBoxes[nGroupIndex]->reorder_child(xEntry->get_widget(), rIndices[nGroupIndex]++); m_aEntries[nGroupIndex].push_back(std::move(xEntry)); @@ -300,13 +294,6 @@ void A11yCheckIssuesPanel::addEntryForGroup(AccessibilityCheckGroups eGroup, std::vector<std::vector<sal_Int32>>& rIndices, std::shared_ptr<sfx::AccessibilityIssue> const& pIssue) { - // prevent the UI locking up forever, this is effectively an O(n^2) situation, given the way the UI additions work - if (m_aLevelEntries[0]->getEntrySize(eGroup) + m_aLevelEntries[1]->getEntrySize(eGroup) > 500) - { - SAL_WARN("sw", "too many a11y issues, not adding to panel"); - return; - } - size_t nLevel = static_cast<size_t>(pIssue->m_eIssueLvl); m_aLevelEntries[nLevel]->addEntryForGroup(eGroup, rIndices[nLevel], pIssue); }