solenv/gbuild/platform/com_GCC_defs.mk | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 7e4f25966760d1e615d137254227097569eca342
Author: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
AuthorDate: Mon Jun 9 00:27:34 2025 +0200
Commit: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
CommitDate: Mon Jun 9 11:19:10 2025 +0200
linux aarch64: use -fsigned-char
pretty much considering it a workaround, better fix would be to use
explicit signed/unsigned variants, but this is what macOS/iOS also use
already/what the code apparently expects.
There doesn't seem to be a major issue, at least none covered by a make
check, but there's at least one WaE issue in oox:
oox/source/vml/vmlinputstream.cxx:45:18: error: result of comparison of
unsigned expression >= 0 is always true
[-Werror,-Wtautological-unsigned-zero-compare]
return cChar >= 0 && cChar <= 32;
~~~~~ ^ ~
1 error generated.
(hit by default with --enable-werror when using gcc (comparison is
always true due to limited range of data type [-Werror=type-limits]),
with clang you have to add -Wtautological-unsigned-zero-compare)
Change-Id: Ib143b446bc842032e98c3d51d973bc0cd3bfcf15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186271
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
diff --git a/solenv/gbuild/platform/com_GCC_defs.mk
b/solenv/gbuild/platform/com_GCC_defs.mk
index 528e45630b25..0dbeecf531f1 100644
--- a/solenv/gbuild/platform/com_GCC_defs.mk
+++ b/solenv/gbuild/platform/com_GCC_defs.mk
@@ -50,6 +50,11 @@ gb_COMPILERDEFS := \
-DCPPU_ENV=$(CPPU_ENV) \
$(if $(filter EMSCRIPTEN,$(OS)),-U_FORTIFY_SOURCE) \
+# FIXME: better to change the code to use explicit types in cour code
+ifeq ($(PLATFORMID),linux_aarch64)
+gb_COMPILERDEFS += -fsigned-char
+endif
+
# enable debug STL
ifeq ($(ENABLE_DBGUTIL),TRUE)
ifneq ($(HAVE_LIBSTDCPP),)
