basic/source/classes/propacc.cxx | 5 +---- chart2/source/controller/dialogs/DialogModel.cxx | 5 +++-- 2 files changed, 4 insertions(+), 6 deletions(-)
New commits: commit 27eb6c557e20058f4ca201e94fd9db96b881763e Author: Stefan Dorneanu <stefcris2...@yahoo.com> AuthorDate: Fri May 16 21:56:01 2025 +0300 Commit: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org> CommitDate: Sat May 31 07:53:16 2025 +0200 tdf#163738 Use insert() to add multiple values in container instead of for loop Signed-off-by: Stefan Dorneanu <cdmail2012...@gmail.com> Change-Id: I6f34abdf199db2cfb14313a600652452ac328079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185432 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org> diff --git a/chart2/source/controller/dialogs/DialogModel.cxx b/chart2/source/controller/dialogs/DialogModel.cxx index 45456d1327b8..1ea7ddfe56d1 100644 --- a/chart2/source/controller/dialogs/DialogModel.cxx +++ b/chart2/source/controller/dialogs/DialogModel.cxx @@ -402,9 +402,10 @@ std::vector< rtl::Reference< ChartType > > xDiagram->getBaseCoordinateSystems()); for( rtl::Reference< BaseCoordinateSystem > const & coords : aCooSysSeq ) { + aResult.insert(aResult.end(), + coords->getChartTypes2().begin(), + coords->getChartTypes2().end()); - for (const auto & rxChartType : coords->getChartTypes2()) - aResult.push_back(rxChartType); } } } commit 6eaf9092546abe3e225ebf847e7a7fd40aa05cd7 Author: Stefan Dorneanu <stefcris2...@yahoo.com> AuthorDate: Fri May 16 21:48:02 2025 +0300 Commit: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org> CommitDate: Sat May 31 07:53:03 2025 +0200 tdf#163738 Used insert() to add multiple values in containers instead of a loop Signed-off-by: Stefan Dorneanu <cdmail2012...@gmail.com> Change-Id: I8175b11dab5204931aaf53c13d4ac8a2e5a2e911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185431 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org> diff --git a/basic/source/classes/propacc.cxx b/basic/source/classes/propacc.cxx index 3f72c50f0683..bfee62092e31 100644 --- a/basic/source/classes/propacc.cxx +++ b/basic/source/classes/propacc.cxx @@ -131,10 +131,7 @@ void SbPropertyValues::setPropertyValues(const Sequence< PropertyValue >& rPrope if (!m_aPropVals.empty()) throw IllegalArgumentException(u"m_aPropVals not empty"_ustr, getXWeak(), -1); - for (const PropertyValue& i : rPropertyValues) - { - m_aPropVals.push_back(i); - } + m_aPropVals.insert(m_aPropVals.end(), rPropertyValues.begin(), rPropertyValues.end()); }