core.git: Branch 'libreoffice-24-8-7' - sw/source

[Caolán McNamara (via logerrit)]

 sw/source/core/layout/tabfrm.cxx |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit e62797fd1a932b74dbcfd9bb98732ddc0f806007
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Fri Apr 18 08:53:28 2025 +0100
Commit:     Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
CommitDate: Wed Apr 30 12:32:01 2025 +0200

    crashtesting: null deref on layout of ooo46450-1.odt
    
    since:
    
    commit b595dff0bf2fcdb63586e36d007408cf23359a65 (HEAD)
    Date:   Fri Apr 11 16:50:43 2025 +0200
    
        tdf#166125 Revert "tdf#158532 sw: fix toolbar buttons remain disabled 
...
    
    Change-Id: I21bf86ffec48e155d1a1f4b9e6ab40555b77a1dc
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184352
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
    (cherry picked from commit b73165c9cc2b5eaa5e1f2a9b9c2dad2f2fa7761b)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184455
    Tested-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>
    Reviewed-by: Christian Lohmaier <lohmaier+libreoff...@googlemail.com>

diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 3cdc8765099d..8a5d9eb71bb5 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -2185,6 +2185,12 @@ static void InvalidateFramePositions(SwFrame * pFrame)
     }
 }
 
+static bool IsFirstNonHeadlineRowDeleteForbidden(const SwTabFrame& rFoll)
+{
+    const SwFrame* pFirstRow = rFoll.GetFirstNonHeadlineRow();
+    return pFirstRow && pFirstRow->IsDeleteForbidden();
+}
+
 void SwTabFrame::MakeAll(vcl::RenderContext* pRenderContext)
 {
     if ( IsJoinLocked() || StackHack::IsLocked() || StackHack::Count() > 50 )
@@ -2615,8 +2621,7 @@ void SwTabFrame::MakeAll(vcl::RenderContext* 
pRenderContext)
             if ( !bSplit && GetFollow() )
             {
                 bool bDummy;
-                if (!(HasFollowFlowLine()
-                        && 
GetFollow()->GetFirstNonHeadlineRow()->IsDeleteForbidden())
+                if (!(HasFollowFlowLine() && 
IsFirstNonHeadlineRowDeleteForbidden(*GetFollow()))
                     && GetFollow()->ShouldBwdMoved(GetUpper(), bDummy))
                 {
                     SwFrame *pTmp = GetUpper();