On 23/07/12 17:41, Caolán McNamara wrote: > So rsvg_handle_new_from_data calls rsvg_handle_close already it turns > out. In new versions of librsvg you can call rsvg_handle_close on a > handle safely as many times as you want, but in older versions like that > of RHEL-5 you can only call it once. > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=682cb83ed59233decbeeaff68c4d871442b58bb1 > > i.e. just drop rsvg_handle_close because rsvg_handle_new_from_data > already did it
i was wondering why you'd removed the content of the then branch until i realized that that is actually error handling code for a failed close call... it's really painful to read code with 2 side effects in the if clause.... pushed to libreoffice-3-5. libreoffice-3-6 2 more necessary for -3-6-0 _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
