basctl/source/basicide/moduldl2.cxx | 4 ++-- vcl/qt5/QtInstanceBuilder.cxx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
New commits: commit 0cd985d302978e4119c9435cdd9d51d9d1d31b8f Author: Michael Weghorn <m.wegh...@posteo.de> AuthorDate: Sat Apr 12 22:07:00 2025 +0200 Commit: Michael Weghorn <m.wegh...@posteo.de> CommitDate: Sun Apr 13 19:17:56 2025 +0200 tdf#130857 qt weld: Support BasicIDE "Go to Line" dialog This means that native Qt widgets are used for that dialog now when using the qt5 or qt6 VCL plugin and starting LO with environment variable SAL_VCL_QT_USE_WELDED_WIDGETS=1 set. This GotoLineDialog can be triggered as follows in Writer: 1) "Tools" -> "Macros" -> "Edit Macros" 2) in Basic IDE click on the info about current line and column in the centre of the status bar (e.g. "Ln 1, Col 1") Change-Id: I32a88d9f3501a60b0c9402c93aaf7169be993d44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184108 Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> Tested-by: Jenkins diff --git a/vcl/qt5/QtInstanceBuilder.cxx b/vcl/qt5/QtInstanceBuilder.cxx index 027d1c6c6606..6a4f817a72c6 100644 --- a/vcl/qt5/QtInstanceBuilder.cxx +++ b/vcl/qt5/QtInstanceBuilder.cxx @@ -92,6 +92,7 @@ bool QtInstanceBuilder::IsUIFileSupported(const OUString& rUIFile) u"filter/ui/xmlfiltertabpagetransformation.ui"_ustr, u"filter/ui/xmlfiltersettings.ui"_ustr, u"filter/ui/xsltfilterdialog.ui"_ustr, + u"modules/BasicIDE/ui/gotolinedialog.ui"_ustr, u"modules/scalc/ui/inputstringdialog.ui"_ustr, u"modules/scalc/ui/insertcells.ui"_ustr, u"modules/scalc/ui/movecopysheet.ui"_ustr, commit d5882d293e97f12b70d6b20dad38aca621d0ddee Author: Michael Weghorn <m.wegh...@posteo.de> AuthorDate: Sat Apr 12 22:02:12 2025 +0200 Commit: Michael Weghorn <m.wegh...@posteo.de> CommitDate: Sun Apr 13 19:17:47 2025 +0200 tdf#130857 basctl: {G,S}et SpinButton value instead of text Just set/get the value directly and leave it to the weld::SpinButton implementation to handle the string <-> value conversion. This GotoLineDialog can be triggered as follows in Writer: 1) "Tools" -> "Macros" -> "Edit Macros" 2) in Basic IDE click on the info about current line and column in the centre of the status bar (e.g. "Ln 1, Col 1") Change-Id: I857ec345d37b35733079aee4d1723f838a438a5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184107 Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> Tested-by: Jenkins diff --git a/basctl/source/basicide/moduldl2.cxx b/basctl/source/basicide/moduldl2.cxx index d97124dceae7..8cc891cf07e8 100644 --- a/basctl/source/basicide/moduldl2.cxx +++ b/basctl/source/basicide/moduldl2.cxx @@ -180,7 +180,7 @@ GotoLineDialog::~GotoLineDialog() sal_Int32 GotoLineDialog::GetLineNumber() const { - return m_xSpinButton->get_text().toInt32(); + return m_xSpinButton->get_value(); } IMPL_LINK_NOARG(GotoLineDialog, OkButtonHandler, weld::Button&, void) @@ -193,7 +193,7 @@ IMPL_LINK_NOARG(GotoLineDialog, OkButtonHandler, weld::Button&, void) } else { - m_xSpinButton->set_text(OUString::number(m_nCurLine)); + m_xSpinButton->set_value(m_nCurLine); m_xSpinButton->select_region(0, -1); } }