core.git: basic/source

[Mike Kaganski (via logerrit)]

 basic/source/comp/dim.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 080198e691c944cdf7553cfa86d52e33c2072f51
Author:     Mike Kaganski <mike.kagan...@collabora.com>
AuthorDate: Fri Apr 11 21:44:53 2025 +0200
Commit:     Mike Kaganski <mike.kagan...@collabora.com>
CommitDate: Sat Apr 12 12:02:50 2025 +0200

    Reorder checks for clarity
    
    Change-Id: I3b18f2dab7b4d7e874548c252730566b2df12798
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/184077
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>

diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index 1e1d44306918..16429d1b523f 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -63,13 +63,13 @@ SbiSymDef* SbiParser::VarDecl( SbiExprListPtr* ppDim, bool 
bStatic, bool bConst
     if( bWithEvents )
         pDef->SetWithEvents();
     TypeDecl( *pDef );
-    if( !ppDim && pDim )
+    if (ppDim)
+        *ppDim = std::move(pDim);
+    else if (pDim)
     {
         if(pDim->GetDims() )
             Error( ERRCODE_BASIC_EXPECTED, u"()"_ustr );
     }
-    else if( ppDim )
-        *ppDim = std::move(pDim);
     return pDef;
 }