xmloff/source/draw/XMLShapeStyleContext.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 93bf5c795f2a4aa3f7e3e3ff102aa0ce7a44b44e
Author:     Noel Grandin <[email protected]>
AuthorDate: Tue Apr 8 09:24:30 2025 +0200
Commit:     Noel Grandin <[email protected]>
CommitDate: Tue Apr 8 18:28:29 2025 +0200

    fix warning C6011: Dereferencing NULL pointer 'pImpPrMap'
    
    from the MSVC analyser, after
    
        commit 8009183a7a4cd1f5b2b6e78e480ade3f10d0eff2
        Author: Noel Grandin <[email protected]>
        Date:   Sat Apr 5 22:03:18 2025 +0200
        tdf#151876 shave some time off chart load (2)
    
    exposed this issue
    
    Change-Id: Ie64f8f4cc8cefa4c47167274c3f54b29e69725a2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183835
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <[email protected]>

diff --git a/xmloff/source/draw/XMLShapeStyleContext.cxx 
b/xmloff/source/draw/XMLShapeStyleContext.cxx
index 4867ab575c3e..06a11050976e 100644
--- a/xmloff/source/draw/XMLShapeStyleContext.cxx
+++ b/xmloff/source/draw/XMLShapeStyleContext.cxx
@@ -200,9 +200,8 @@ void XMLShapeStyleContext::FillPropertySet( const 
Reference< beans::XPropertySet
 
     SvXMLImportPropertyMapper* pImpPrMap =
         GetStyles()->GetImportPropertyMapper( GetFamily() );
-    SAL_WARN_IF( !pImpPrMap, "xmloff", "There is the import prop mapper" );
-    if( pImpPrMap )
-        pImpPrMap->FillPropertySet( GetProperties(), rPropSet, aContextIDs );
+    assert( pImpPrMap );
+    pImpPrMap->FillPropertySet( GetProperties(), rPropSet, aContextIDs );
 
     Reference< XPropertySetInfo > xInfo;
     // get property set mapper

Reply via email to