desktop/source/app/crashreport.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
New commits: commit 26d0af9ddc98355865c62ce0ffc04c3919ebce87 Author: Stephan Bergmann <stephan.bergm...@allotropia.de> AuthorDate: Sun Mar 16 11:23:23 2025 +0100 Commit: Stephan Bergmann <stephan.bergm...@allotropia.de> CommitDate: Sun Mar 16 12:27:53 2025 +0100 Revert "tdf#158068: Replace with static constexpr O(U)String" This reverts commit 817cb41005db87c9bdd63663e5d1d1357d6e5cbc, as it causes > desktop/source/app/crashreport.cxx:197:26: error: view pointing into temporary i.e. dangling [loplugin:stringviewdangle] > 197 | aCommandSeperator=u","_ustr; > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~ Change-Id: I787e4997c536f8bb37973da33c9ca1d660f2698c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182993 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de> diff --git a/desktop/source/app/crashreport.cxx b/desktop/source/app/crashreport.cxx index 82e861a99090..18db12d07b38 100644 --- a/desktop/source/app/crashreport.cxx +++ b/desktop/source/app/crashreport.cxx @@ -188,13 +188,13 @@ OUString CrashReporter::getLoggedUnoCommands() { osl::MutexGuard aGuard(maUnoLogCmdMutex); - std::u16string_view aCommandSeperator; + OUString aCommandSeperator=""; OUStringBuffer aUnoCommandBuffer; for( auto& unocommand: maloggedUnoCommands) { aUnoCommandBuffer.append(aCommandSeperator + unocommand); - aCommandSeperator=u","_ustr; + aCommandSeperator=","; } return aUnoCommandBuffer.makeStringAndClear(); }