Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
3 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)
** CID 1643905: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tpbitmap.cxx: 614 in
SvxBitmapTabPage::SvxPresetListBoxValueSet::SvxPresetListBoxValueSet(std::unique_ptr<weld::ScrolledWindow,
std::default_delete<weld::ScrolledWindow>>)()
________________________________________________________________________________________________________
*** CID 1643905: Uninitialized members (UNINIT_CTOR)
/cui/source/tabpages/tpbitmap.cxx: 614 in
SvxBitmapTabPage::SvxPresetListBoxValueSet::SvxPresetListBoxValueSet(std::unique_ptr<weld::ScrolledWindow,
std::default_delete<weld::ScrolledWindow>>)()
608 }
609
610
611
SvxBitmapTabPage::SvxPresetListBoxValueSet::SvxPresetListBoxValueSet(std::unique_ptr<weld::ScrolledWindow>
pWindow)
612 : SvxPresetListBox(std::move(pWindow))
613 {
>>> CID 1643905: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "m_pSvxBitmapTabPage" is not initialized in
>>> this constructor nor in any functions that it calls.
614 }
615
616 bool SvxBitmapTabPage::SvxPresetListBoxValueSet::KeyInput(const
KeyEvent& rKEvt)
617 {
618 switch (rKEvt.GetKeyCode().GetCode())
619 {
** CID 1643904: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/forms/source/component/FormattedFieldWrapper.cxx: 96 in
frm::OFormattedFieldWrapper::createClone()()
________________________________________________________________________________________________________
*** CID 1643904: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/forms/source/component/FormattedFieldWrapper.cxx: 96 in
frm::OFormattedFieldWrapper::createClone()()
90 if ( m_xAggregate.is() )
91 {
92 rtl::Reference< OEditBaseModel > xClone =
static_cast<OEditBaseModel*>(m_xAggregate->createClone().get());
93 xRef->m_xAggregate = xClone;
94 OSL_ENSURE(xRef->m_xAggregate.is(), "invalid aggregate cloned
!");
95
>>> CID 1643904: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xClone" is copied in a call to copy assignment "operator =", when it
>>> could be moved instead.
96 xRef->m_xFormattedPart = xClone;
97
98 if ( m_pEditPart.is() )
99 {
100 xRef->m_pEditPart.set( new OEditModel(m_pEditPart.get(),
m_xContext) );
101 }
** CID 1643903: Null pointer dereferences (REVERSE_INULL)
/sc/source/ui/view/gridwin3.cxx: 60 in ScGridWindow::DrawMouseButtonDown(const
MouseEvent &)()
________________________________________________________________________________________________________
*** CID 1643903: Null pointer dereferences (REVERSE_INULL)
/sc/source/ui/view/gridwin3.cxx: 60 in ScGridWindow::DrawMouseButtonDown(const
MouseEvent &)()
54 bool ScGridWindow::DrawMouseButtonDown(const MouseEvent& rMEvt)
55 {
56 bool bRet = false;
57 FuPoor* pDraw = mrViewData.GetView()->GetDrawFuncPtr();
58 pDraw->ResetSelectionHasChanged();
59 ScDrawView* pDrView = mrViewData.GetScDrawView();
>>> CID 1643903: Null pointer dereferences (REVERSE_INULL)
>>> Null-checking "pDraw" suggests that it may be null, but it has already
>>> been dereferenced on all paths leading to the check.
60 if (pDraw && !mrViewData.IsRefMode())
61 {
62 MapMode aDrawMode = GetDrawMapMode();
63 MapMode aOldMode = GetMapMode();
64 if ( comphelper::LibreOfficeKit::isActive() && aOldMode !=
aDrawMode )
65 SetMapMode( aDrawMode );
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
