compilerplugins/clang/constantparam.bitmask.results | 2
compilerplugins/clang/constantparam.booleans.results | 64 ++-------------
compilerplugins/clang/constantparam.constructors.results | 6 +
compilerplugins/clang/constantparam.numbers.results | 2
xmloff/inc/txtflde.hxx | 2
xmloff/source/text/txtflde.cxx | 4
xmloff/source/text/txtparae.cxx | 3
7 files changed, 22 insertions(+), 61 deletions(-)
New commits:
commit 31d4a7bd3760ecb087c61cd6ae5095493820d230
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Feb 26 17:55:00 2025 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Fri Feb 28 07:36:21 2025 +0100
loplugin:constantparam
Change-Id: I8184c75ea6f35538eb68faa9eaf18b6d053f843c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/182309
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/compilerplugins/clang/constantparam.bitmask.results
b/compilerplugins/clang/constantparam.bitmask.results
index e59a6f94ad1d..c29783309c3d 100644
--- a/compilerplugins/clang/constantparam.bitmask.results
+++ b/compilerplugins/clang/constantparam.bitmask.results
@@ -37,7 +37,7 @@ sc/source/ui/view/cellsh1.cxx:131
starmath/inc/mathml/export.hxx:199
void SmMLExport::SmMLExport(const class
com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext>
&,const class rtl::OUString &,enum SvXMLExportFlags)
enum SvXMLExportFlags nExportFlags setBits=0x8000 clearBits=0x7a00
-sw/source/core/view/viewsh.cxx:859
+sw/source/core/view/viewsh.cxx:862
void lcl_InvalidateAllContent(class SwViewShell &,enum SwInvalidateFlags)
enum SwInvalidateFlags nInv setBits=0x2
sw/source/filter/html/swhtml.hxx:700
diff --git a/compilerplugins/clang/constantparam.booleans.results
b/compilerplugins/clang/constantparam.booleans.results
index 6921dd4762b5..bf397b1c990f 100644
--- a/compilerplugins/clang/constantparam.booleans.results
+++ b/compilerplugins/clang/constantparam.booleans.results
@@ -1074,10 +1074,6 @@ include/package/Inflater.hxx:43
void ZipUtils::Inflater::Inflater(_Bool)
_Bool bNoWrap
1
-include/package/Inflater.hxx:65
- void ZipUtils::InflaterBytes::InflaterBytes(_Bool)
- _Bool bNoWrap
- 1
include/package/Inflater.hxx:69
int ZipUtils::InflaterBytes::doInflateSegment(signed char *,int,int,int)
int nNewOffset
@@ -1342,14 +1338,6 @@ include/svtools/valueset.hxx:350
void ValueSet::SetItemColor(unsigned short,const class Color &)
unsigned short nItemId
1
-include/svx/colorbox.hxx:56
- void ColorListBox::ColorListBox(class std::unique_ptr<class
weld::MenuButton>,class std::function<class weld::Window *(void)>,const class
ColorListBox *)
- const class ColorListBox * pCache
- 0
-include/svx/ColorSets.hxx:42
- void svx::ColorSets::insert(const class model::ColorSet &,enum
svx::ColorSets::IdenticalNameAction)
- enum svx::ColorSets::IdenticalNameAction eAction
- 1
include/svx/ctredlin.hxx:218
void SvxTPFilter::SelectedAuthorPos(int)
int nPos
@@ -1982,10 +1970,6 @@ include/vcl/vectorgraphicdata.hxx:84
void VectorGraphicData::VectorGraphicData(class BinaryDataContainer,enum
VectorGraphicDataType,int)
enum VectorGraphicDataType eVectorDataType
0
-include/vcl/virdev.hxx:58
- _Bool VirtualDevice::InnerImplSetOutputSizePixel(const class Size
&,_Bool,unsigned char *)
- unsigned char * pBuffer
- 0
include/vcl/weld.hxx:423
void weld::Grid::set_child_column_span(class weld::Widget &,int)
int nCols
@@ -2054,16 +2038,12 @@ include/xmloff/txtparae.hxx:227
void XMLTextParagraphExport::exportText(const class
com::sun::star::uno::Reference<class com::sun::star::text::XText> &,const class
com::sun::star::uno::Reference<class com::sun::star::text::XTextSection>
&,_Bool,_Bool,_Bool)
_Bool bExportParagraph
1
-include/xmloff/txtparae.hxx:255
- void XMLTextParagraphExport::exportTextField(const class
com::sun::star::uno::Reference<class com::sun::star::text::XTextField> &,const
_Bool,const _Bool,const _Bool,_Bool *)
- const _Bool bRecursive
- 1
include/xmloff/txtparae.hxx:269
void XMLTextParagraphExport::exportTextFrame(const class
com::sun::star::uno::Reference<class com::sun::star::text::XTextContent>
&,_Bool,_Bool,_Bool,const class com::sun::star::uno::Reference<class
com::sun::star::beans::XPropertySet> *)
_Bool bExportContent
1
-include/xmloff/txtparae.hxx:396
- void XMLTextParagraphExport::Add(enum XmlStyleFamily,const class
com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySet>
&,class std::span<const struct XMLPropertyState>,_Bool)
+include/xmloff/xmlaustp.hxx:115
+ class rtl::OUString SvXMLAutoStylePoolP::Add(enum XmlStyleFamily,const
class rtl::OUString &,class std::vector<struct XMLPropertyState> &&,_Bool)
_Bool bDontSeek
0
include/xmloff/XMLEventExport.hxx:89
@@ -2662,19 +2642,19 @@ sc/inc/postit.hxx:64
void ScPostIt::ScPostIt(class ScDocument &,const class ScAddress
&,unsigned int)
unsigned int nPostItId
0
-sc/inc/queryiter.hxx:368
+sc/inc/queryiter.hxx:372
void ScQueryCellIteratorSortedCache::ScQueryCellIteratorSortedCache(class
ScDocument &,struct ScInterpreterContext &,short,const struct ScQueryParam
&,_Bool,_Bool)
_Bool bMod
0
-sc/inc/queryiter.hxx:368
+sc/inc/queryiter.hxx:372
void ScQueryCellIteratorSortedCache::ScQueryCellIteratorSortedCache(class
ScDocument &,struct ScInterpreterContext &,short,const struct ScQueryParam
&,_Bool,_Bool)
_Bool bReverse
0
-sc/inc/queryiter.hxx:418
+sc/inc/queryiter.hxx:422
void
ScCountIfCellIteratorSortedCache::ScCountIfCellIteratorSortedCache(class
ScDocument &,struct ScInterpreterContext &,short,const struct ScQueryParam
&,_Bool,_Bool)
_Bool bMod
0
-sc/inc/queryiter.hxx:418
+sc/inc/queryiter.hxx:422
void
ScCountIfCellIteratorSortedCache::ScCountIfCellIteratorSortedCache(class
ScDocument &,struct ScInterpreterContext &,short,const struct ScQueryParam
&,_Bool,_Bool)
_Bool bReverse
0
@@ -2926,11 +2906,11 @@ sc/source/core/data/postit.cxx:371
void (anonymous
namespace)::ScNoteCaptionCreator::ScNoteCaptionCreator(class ScDocument &,const
class ScAddress &,class rtl::Reference<class SdrCaptionObj> &,_Bool)
_Bool bShown
1
-sc/source/core/inc/interpre.hxx:501
+sc/source/core/inc/interpre.hxx:502
short ScInterpreter::GetInt16WithDefault(short)
short nDefault
1
-sc/source/core/inc/interpre.hxx:505
+sc/source/core/inc/interpre.hxx:506
_Bool ScInterpreter::GetBoolWithDefault(_Bool)
_Bool bDefault
0
@@ -3582,18 +3562,6 @@
sd/source/ui/slidesorter/inc/controller/SlsPageSelector.hxx:100
_Bool sd::slidesorter::controller::PageSelector::IsPageExcluded(int)
int nPageIndex
0
-sd/source/ui/slidesorter/inc/view/SlsLayouter.hxx:160
- int sd::slidesorter::view::Layouter::GetIndexAtPoint(const class Point
&,const _Bool,const _Bool) const
- const _Bool bIncludePageBorders
- 0
-sd/source/ui/slidesorter/inc/view/SlsLayouter.hxx:160
- int sd::slidesorter::view::Layouter::GetIndexAtPoint(const class Point
&,const _Bool,const _Bool) const
- const _Bool bClampToValidRange
- 0
-sd/source/ui/view/ToolBarManager.cxx:261
- void sd::ToolBarManager::Implementation::AddToolBarShell(enum
sd::ToolBarManager::ToolBarGroup,enum ToolbarId,_Bool)
- _Bool bAddBar
- 1
sdext/source/minimizer/configurationaccess.hxx:90
short ConfigurationAccess::GetConfigProperty(const enum
PPPOptimizerTokenEnum,const short) const
const short nDefault
@@ -3934,10 +3902,6 @@ sw/inc/node.hxx:443
_Bool SwContentNode::GoNext(struct SwPosition &,enum SwCursorSkipMode)
const
enum SwCursorSkipMode nMode
0
-sw/inc/node.hxx:452
- class SwRect SwContentNode::FindLayoutRect(const _Bool,const class Point
*) const
- const _Bool bPrtArea
- 0
sw/inc/pam.hxx:199
void SwPaM::SwPaM(const class SwNodeIndex &,const class SwNodeIndex
&,struct o3tl::strong_int<int, struct Tag_SwNodeOffset>,struct
o3tl::strong_int<int, struct Tag_SwNodeOffset>,class SwPaM *)
class SwPaM * pRing
@@ -4042,10 +4006,6 @@ sw/source/core/access/accmap.cxx:429
void SwAccessibleEvent_Impl::SwAccessibleEvent_Impl(enum
SwAccessibleEvent_Impl::EventType,class SwAccessibleContext *,class
sw::access::SwAccessibleChild,const enum AccessibleStates)
enum SwAccessibleEvent_Impl::EventType eT
0
-sw/source/core/crsr/pam.cxx:395
- class SwContentNode * GoPreviousNds(class SwNodeIndex *,_Bool)
- _Bool bChk
- 1
sw/source/core/crsr/swcrsr.cxx:75
void (anonymous namespace)::PercentHdl::PercentHdl(unsigned long,unsigned
long,class SwDocShell *)
unsigned long nStt
@@ -4118,10 +4078,6 @@ sw/source/core/inc/UndoTable.hxx:263
void SwUndoTableNumFormat::SwUndoTableNumFormat(const class SwTableBox
&,const class SfxItemSet *)
const class SfxItemSet * pNewSet
0
-sw/source/core/inc/viewimp.hxx:195
- void SwViewShellImp::PaintLayer(const struct o3tl::strong_int<short,
struct SdrLayerIDTag>,const class SwPrintData *const,const class SwPageFrame
&,const class SwRect &,const class Color *,const _Bool,class
sdr::contact::ViewObjectContactRedirector *)
- const class SwPrintData *const pPrintData
- 0
sw/source/core/inc/wrong.hxx:346
void SwWrongList::InsertSubList(int,int,unsigned short,class SwWrongList *)
int nNewLen
@@ -4730,6 +4686,10 @@ xmlhelp/source/cxxhelp/provider/databases.hxx:377
void chelp::DataBaseIterator::DataBaseIterator(class chelp::Databases
&,const class rtl::OUString &,const class rtl::OUString &,_Bool)
_Bool bHelpText
0
+xmloff/inc/txtflde.hxx:175
+ void XMLTextFieldExport::ExportFieldAutoStyle(const class
com::sun::star::uno::Reference<class com::sun::star::text::XTextField> &,const
_Bool,const _Bool)
+ const _Bool bRecursive
+ 1
xmloff/inc/txtflde.hxx:260
void XMLTextFieldExport::ProcessIntegerDef(enum
xmloff::token::XMLTokenEnum,int,int)
int nDefault
diff --git a/compilerplugins/clang/constantparam.constructors.results
b/compilerplugins/clang/constantparam.constructors.results
index 710f8005148a..9a7cf94eb7d4 100644
--- a/compilerplugins/clang/constantparam.constructors.results
+++ b/compilerplugins/clang/constantparam.constructors.results
@@ -422,6 +422,10 @@ include/svx/charmap.hxx:150
void SvxShowCharSet::DrawChars_Impl(class OutputDevice &,int,int)
int n2
LastInView()
+include/svx/colorbox.hxx:48
+ void ColorListBox::LockWidthRequest(int)
+ int nWidthRequest
+ CalcBestWidthRequest()
include/svx/colorwindow.hxx:110
void ColorWindow::ColorWindow(class rtl::OUString,class
std::shared_ptr<class PaletteManager>,class ColorStatus &,unsigned short,const
class com::sun::star::uno::Reference<class com::sun::star::frame::XFrame>
&,const class MenuOrToolMenuButton &,class std::function<class weld::Window
*(void)>,class std::function<void (const class rtl::OUString &, const struct
NamedColor &)>)
class rtl::OUString rCommand
@@ -494,7 +498,7 @@ include/vcl/toolkit/svlbitm.hxx:111
void SvLBoxString::SvLBoxString(class rtl::OUString)
class rtl::OUString aText
""
-include/vcl/virdev.hxx:126
+include/vcl/virdev.hxx:125
_Bool VirtualDevice::SetOutputSizePixelScaleOffsetAndLOKBuffer(const class
Size &,const class Fraction &,const class Point &,unsigned char *)
const class Point & rNewOffset
Point()
diff --git a/compilerplugins/clang/constantparam.numbers.results
b/compilerplugins/clang/constantparam.numbers.results
index 74cd1110d78f..6a65d29cc757 100644
--- a/compilerplugins/clang/constantparam.numbers.results
+++ b/compilerplugins/clang/constantparam.numbers.results
@@ -2942,7 +2942,7 @@ sw/qa/core/Test-BigPtrArray.cxx:53
void fillBigPtrArray(class BigPtrArray &,int)
int numEntries
10
-sw/qa/extras/ooxmlexport/ooxmlexport12.cxx:2161
+sw/qa/extras/ooxmlexport/ooxmlexport12.cxx:2171
_Bool lcl_nearEqual(const int,const int,int)
int nMaxDiff
5
diff --git a/xmloff/inc/txtflde.hxx b/xmloff/inc/txtflde.hxx
index 06d5edcaa2b4..60065d90095b 100644
--- a/xmloff/inc/txtflde.hxx
+++ b/xmloff/inc/txtflde.hxx
@@ -173,7 +173,7 @@ public:
/// Also collect used field masters (if pUsedMasters is set)
/// to be called for every field during style export.
void ExportFieldAutoStyle(const css::uno::Reference <
css::text::XTextField > & rTextField,
- const bool bProgress, const bool bRecursive );
+ const bool bProgress );
/// export field declarations.
/// to be called once at beginning of document body.
diff --git a/xmloff/source/text/txtflde.cxx b/xmloff/source/text/txtflde.cxx
index 1d932dc300bc..3f2ac6b452f3 100644
--- a/xmloff/source/text/txtflde.cxx
+++ b/xmloff/source/text/txtflde.cxx
@@ -763,8 +763,7 @@ bool XMLTextFieldExport::IsStringField(
/// export the styles needed by the given field. Called on first pass
/// through document
void XMLTextFieldExport::ExportFieldAutoStyle(
- const Reference<XTextField> & rTextField, const bool bProgress,
- const bool bRecursive )
+ const Reference<XTextField> & rTextField, const bool bProgress )
{
// get property set
Reference<XPropertySet> xPropSet(rTextField, UNO_QUERY);
@@ -854,7 +853,6 @@ void XMLTextFieldExport::ExportFieldAutoStyle(
case FIELD_ID_META:
// recurse into content (does not export element, so can be done first)
- if (bRecursive)
{
bool dummy_for_autostyles(true);
ExportMetaField(xPropSet, true, bProgress, dummy_for_autostyles);
diff --git a/xmloff/source/text/txtparae.cxx b/xmloff/source/text/txtparae.cxx
index c4ffb513d731..46c5c46eebd9 100644
--- a/xmloff/source/text/txtparae.cxx
+++ b/xmloff/source/text/txtparae.cxx
@@ -2615,8 +2615,7 @@ void XMLTextParagraphExport::exportTextField(
{
if ( bAutoStyles )
{
- m_pFieldExport->ExportFieldAutoStyle( xTextField, bIsProgress,
- /*bRecursive*/ true );
+ m_pFieldExport->ExportFieldAutoStyle( xTextField, bIsProgress );
}
else
{
