external/firebird/sanitizer.patch |    9 +++++++++
 1 file changed, 9 insertions(+)

New commits:
commit a03edb923d88789c86b68f62e7cc58f89d94a863
Author:     Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Thu Feb 6 15:03:47 2025 +0100
Commit:     Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Thu Feb 6 16:47:11 2025 +0100

    external/firebird: Drop -fno-rtti from sanitizer builds
    
    Until now, at least Clang silently drops -fsanitize=vptr (which needs RTTI, 
and
    which is by default included in -fsanitize=undefined) from 
-fsanitize=undefined,
    that's how external/firebird (which uses -fno-rtti) worked for now with
    -fsanitize=undefined.  However, Clang is planing to break -fsanitize=vptr 
out of
    -fsanitize=undefined (see
    <https://discourse.llvm.org/t/rfc-remove-vptr-from-undefined/83830> "[RFC]
    Remove `vptr` from `undefined`"), so to be prepared for that I started to 
do my
    local ASan/UBSan build with an explicit -fsanitize=vptr already.  Which thus
    started to cause
    
    > clang++: error: invalid argument '-fsanitize=vptr' not allowed with 
'-fno-rtti'
    
    But there appears to be no good reason to do such instrumented builds with
    -fno-rtti anyway.
    
    Change-Id: I9f579846a6c0f666d071d3432d17b266d8ef339e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181213
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>

diff --git a/external/firebird/sanitizer.patch 
b/external/firebird/sanitizer.patch
index 3707b5bf54af..8f2a1e54df53 100644
--- a/external/firebird/sanitizer.patch
+++ b/external/firebird/sanitizer.patch
@@ -21,6 +21,15 @@
 +_ZTI*
 --- builds/posix/make.defaults
 +++ builds/posix/make.defaults
+@@ -102,7 +102,7 @@
+ #____________________________________________________________________________
+ 
+ # Firebird needs no RTTI
+-RTTI_FLAG:= -fno-rtti
++RTTI_FLAG:=
+ 
+ # If this is defined then we use special rules useful for developers only
+ IsDeveloper = @DEVEL_FLG@
 @@ -252,7 +252,7 @@
  # LINKER OPTIONS
  #

Reply via email to