svtools/source/brwbox/brwbox2.cxx | 4 +---
svx/source/engine3d/svx3ditems.cxx | 2 --
2 files changed, 1 insertion(+), 5 deletions(-)
New commits:
commit 69c0b537bfa05a6193e212105d166c26492124f6
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Feb 4 19:30:47 2025 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Wed Feb 5 08:38:03 2025 +0100
browsebox a11y: Drop incorrect parent-relative pos conversion
The only thing that changes when parent-relative coordinates
(and not screen coordinates) are used is that the origin
of the rectangle is different, which is already handled below.
Passing bRelToBrowser=false to BrowseBox::GetFieldRectPixel
is incorrect and resulted in the position for BrowseBox
headers cells being incorrectly reported on the a11y layer
when parent-relative coordinates are used.
This was observed with an upcoming commit to let
AccessibleBrowseBoxBase derive from OAccessibleComponentHelper
and could be seen e.g. with the table seen in the
Base window that shows up when selecting
"Create Table in Design View..." in the "Tables" tab after
creating a new database. (Highlighted position for
those was wrong in Accerciser when selected in the
a11y tree view there when using the qt6 VCL plugin.)
Change-Id: I4c68748db0f09787037ac1ef023febaf01d1156e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181145
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
Tested-by: Jenkins
diff --git a/svtools/source/brwbox/brwbox2.cxx
b/svtools/source/brwbox/brwbox2.cxx
index c02069fea856..f613bdcb26e4 100644
--- a/svtools/source/brwbox/brwbox2.cxx
+++ b/svtools/source/brwbox/brwbox2.cxx
@@ -1993,7 +1993,7 @@ tools::Rectangle BrowseBox::GetFieldRectPixel( sal_Int32
_nRowId, sal_uInt16 _nC
if ( !_bOnScreen )
pParent = GetAccessibleParentWindow();
- tools::Rectangle aRect = GetFieldRectPixel(_nRowId,_nColId,_bOnScreen);
+ tools::Rectangle aRect = GetFieldRectPixel(_nRowId, _nColId, true);
Point aTopLeft = aRect.TopLeft();
if (pParent)
commit 9b9d6a99e1509a03648fd6af0310e44c3fba5b14
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Tue Feb 4 19:21:28 2025 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Wed Feb 5 08:37:50 2025 +0100
Drop EOF comments
No need to add a comment that the end of the (source)
file is near, it's sufficiently obvious...
Change-Id: Iac8885cf67fce45a81de387a31f8b726d615dff1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181140
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/svtools/source/brwbox/brwbox2.cxx
b/svtools/source/brwbox/brwbox2.cxx
index 6762120b266c..c02069fea856 100644
--- a/svtools/source/brwbox/brwbox2.cxx
+++ b/svtools/source/brwbox/brwbox2.cxx
@@ -2004,6 +2004,4 @@ tools::Rectangle BrowseBox::GetFieldRectPixel( sal_Int32
_nRowId, sal_uInt16 _nC
return tools::Rectangle(aTopLeft,aRect.GetSize());
}
-// -------------------------------------------------------------------------
EOF
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/engine3d/svx3ditems.cxx
b/svx/source/engine3d/svx3ditems.cxx
index 1bfa4f559111..f3b2e0c8c44a 100644
--- a/svx/source/engine3d/svx3ditems.cxx
+++ b/svx/source/engine3d/svx3ditems.cxx
@@ -272,6 +272,4 @@ Svx3DShadeModeItem* Svx3DShadeModeItem::Clone(SfxItemPool*
/*pPool*/) const
return new Svx3DShadeModeItem(*this);
}
-// EOF
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
