sfx2/source/sidebar/TabBar.cxx | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit d5617cd2a26c023eaf9e6b4df379a07aab63d0be
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Mon Feb 3 19:29:57 2025 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Feb 4 00:34:24 2025 +0100
sidebar: Have sidebar deck tooltip only set on its button
Drop the tooltip from the toolbar that contains the
button.
This is already set for the button as well since
commit 9fdc7384eff0e9627de2d9c2b59a7716f9e8af25
Date: Tue Dec 15 14:33:32 2020 +0000
tdf#138938 put the tooltip on the toolbar item instead of the
toolbar
, so setting it on the toolbar in addition seems unnecessary.
(The tooltip showed fine in a quick test with both, gtk3
and gen as expected.)
commit bb1d48498c9fdedf8e78344765f6c6eda6f4707c
Date: Wed May 18 22:22:06 2022 -0800
tdf#84502 related: Show keyboard shortcut in sidebar tab bar tab
button
had added the shortcut in the tooltip text set for the button,
but not the toolbar, but having these two different variants
doesn't look intentional to me.
Change-Id: I6bdc72d00b33c8a970777ed94a6911042db309ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181074
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
Tested-by: Jenkins
diff --git a/sfx2/source/sidebar/TabBar.cxx b/sfx2/source/sidebar/TabBar.cxx
index 1ae9799dcac0..1506c1b7cf21 100644
--- a/sfx2/source/sidebar/TabBar.cxx
+++ b/sfx2/source/sidebar/TabBar.cxx
@@ -230,7 +230,6 @@ bool TabBar::EventNotify(NotifyEvent& rEvent)
void TabBar::CreateTabItem(weld::Toolbar& rItem, const DeckDescriptor&
rDeckDescriptor)
{
rItem.set_accessible_description(rDeckDescriptor.msHelpText);
- rItem.set_tooltip_text(rDeckDescriptor.msHelpText);
const OUString sCommand = ".uno:SidebarDeck." + rDeckDescriptor.msId;
OUString sShortcut =
vcl::CommandInfoProvider::GetCommandShortcut(sCommand, mxFrame);
if (!sShortcut.isEmpty())
commit bd9666444d0b914d4102a4ce9446148d7e258a0c
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Mon Feb 3 19:23:24 2025 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Tue Feb 4 00:34:16 2025 +0100
tdf#165002 sidebar a11y: Set a11y name on sidebar deck buttons
For sidebar deck tool buttons, set the accessible name
for the actual button, not the toolbar that contains it.
That makes the Orca screen reader announce the name
when the button receives focus instead of just announcing
that a button received focus, leaving it unclear for the
user what this button is about.
Change-Id: I80b3ed45b57ba7cf10b7a46bb0506fdccde55f27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/181073
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/sfx2/source/sidebar/TabBar.cxx b/sfx2/source/sidebar/TabBar.cxx
index 8993b10fd92d..1ae9799dcac0 100644
--- a/sfx2/source/sidebar/TabBar.cxx
+++ b/sfx2/source/sidebar/TabBar.cxx
@@ -229,13 +229,13 @@ bool TabBar::EventNotify(NotifyEvent& rEvent)
void TabBar::CreateTabItem(weld::Toolbar& rItem, const DeckDescriptor&
rDeckDescriptor)
{
- rItem.set_accessible_name(rDeckDescriptor.msTitle);
rItem.set_accessible_description(rDeckDescriptor.msHelpText);
rItem.set_tooltip_text(rDeckDescriptor.msHelpText);
const OUString sCommand = ".uno:SidebarDeck." + rDeckDescriptor.msId;
OUString sShortcut =
vcl::CommandInfoProvider::GetCommandShortcut(sCommand, mxFrame);
if (!sShortcut.isEmpty())
sShortcut = u" (" + sShortcut + u")";
+ rItem.set_item_accessible_name(u"toggle"_ustr, rDeckDescriptor.msTitle);
rItem.set_item_tooltip_text(u"toggle"_ustr, rDeckDescriptor.msHelpText +
sShortcut);
}
