desktop/source/migration/migration.cxx |   15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

New commits:
commit 4cc35cf5d52b2e6f9458b27ea6b26a9ebd066af0
Author:     Simon Chenery <simon_chen...@yahoo.com>
AuthorDate: Mon Jan 27 18:42:45 2025 +0100
Commit:     Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>
CommitDate: Mon Feb 3 11:34:18 2025 +0100

    tdf#163738 use insert function instead of for loop in migration.cxx
    
    Change-Id: Icf49d59fa56b6c7074abd476deeca040ea4c178f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180801
    Tested-by: Jenkins
    Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakan...@libreoffice.org>

diff --git a/desktop/source/migration/migration.cxx 
b/desktop/source/migration/migration.cxx
index da01086b7a17..5006bc1c5507 100644
--- a/desktop/source/migration/migration.cxx
+++ b/desktop/source/migration/migration.cxx
@@ -347,32 +347,27 @@ migrations_vr MigrationImpl::readMigrationSteps(const 
OUString& rMigrationName)
 
         // read included files from current step description
         if (tmpAccess->getByName(u"IncludedFiles"_ustr) >>= tmpSeq) {
-            for (const OUString& rSeqEntry : tmpSeq)
-                tmpStep.includeFiles.push_back(rSeqEntry);
+            tmpStep.includeFiles.insert(tmpStep.includeFiles.end(), 
tmpSeq.begin(), tmpSeq.end());
         }
 
         // excluded files...
         if (tmpAccess->getByName(u"ExcludedFiles"_ustr) >>= tmpSeq) {
-            for (const OUString& rSeqEntry : tmpSeq)
-                tmpStep.excludeFiles.push_back(rSeqEntry);
+            tmpStep.excludeFiles.insert(tmpStep.excludeFiles.end(), 
tmpSeq.begin(), tmpSeq.end());
         }
 
         // included nodes...
         if (tmpAccess->getByName(u"IncludedNodes"_ustr) >>= tmpSeq) {
-            for (const OUString& rSeqEntry : tmpSeq)
-                tmpStep.includeConfig.push_back(rSeqEntry);
+            tmpStep.includeConfig.insert(tmpStep.includeConfig.end(), 
tmpSeq.begin(), tmpSeq.end());
         }
 
         // excluded nodes...
         if (tmpAccess->getByName(u"ExcludedNodes"_ustr) >>= tmpSeq) {
-            for (const OUString& rSeqEntry : tmpSeq)
-                tmpStep.excludeConfig.push_back(rSeqEntry);
+            tmpStep.excludeConfig.insert(tmpStep.excludeConfig.end(), 
tmpSeq.begin(), tmpSeq.end());
         }
 
         // excluded extensions...
         if (tmpAccess->getByName(u"ExcludedExtensions"_ustr) >>= tmpSeq) {
-            for (const OUString& rSeqEntry : tmpSeq)
-                tmpStep.excludeExtensions.push_back(rSeqEntry);
+            tmpStep.excludeExtensions.insert(tmpStep.excludeExtensions.end(), 
tmpSeq.begin(), tmpSeq.end());
         }
 
         // generic service

Reply via email to