include/vcl/accessibletable.hxx | 7 ------- toolkit/inc/controls/table/tablecontrol.hxx | 5 ----- toolkit/source/controls/table/tablecontrol.cxx | 25 ------------------------- 3 files changed, 37 deletions(-)
New commits: commit dd3fae8818d0685fb67a2fad8e0b42f3de7c2fea Author: Michael Weghorn <m.wegh...@posteo.de> AuthorDate: Fri Jan 24 10:29:30 2025 +0100 Commit: Michael Weghorn <m.wegh...@posteo.de> CommitDate: Fri Jan 24 22:00:36 2025 +0100 toolkit a11y: Drop methods just calling their base class implementations These were only needed before commit c6c471546ee82d939092da3ac25a6548145c56c9 Author: Michael Weghorn <m.wegh...@posteo.de> Date: Thu Jan 23 17:29:32 2025 +0100 toolkit a11y: Use pointers/refs to concrete TableControl class to be able to call them with only a pointer/ref to the abstract IAccessibleTable base class. Change-Id: I9d148babaa4ac7210d9b1d3a81d7361ff8eab438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180695 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> diff --git a/include/vcl/accessibletable.hxx b/include/vcl/accessibletable.hxx index e7d49b3935e9..6a8ee6034423 100644 --- a/include/vcl/accessibletable.hxx +++ b/include/vcl/accessibletable.hxx @@ -71,11 +71,6 @@ public: AccessibleTableControlObjType eObjType ) const= 0; // Window - virtual AbsoluteScreenPixelRectangle GetWindowExtentsAbsolute() const = 0; - virtual tools::Rectangle GetWindowExtentsRelative(const vcl::Window& rRelativeWindow) const = 0; - virtual void GrabFocus()= 0; - virtual css::uno::Reference< css::accessibility::XAccessible > GetAccessible()= 0; - virtual vcl::Window* GetAccessibleParentWindow() const= 0; virtual vcl::Window* GetWindowInstance()= 0; virtual sal_Int32 GetAccessibleControlCount() const = 0; virtual bool ConvertPointToControlIndex( sal_Int32& _rnIndex, const Point& _rPoint )= 0; diff --git a/toolkit/inc/controls/table/tablecontrol.hxx b/toolkit/inc/controls/table/tablecontrol.hxx index 075e3b83ebe5..72bdcec4fc79 100644 --- a/toolkit/inc/controls/table/tablecontrol.hxx +++ b/toolkit/inc/controls/table/tablecontrol.hxx @@ -125,11 +125,6 @@ namespace svt::table // IAccessibleTable - virtual AbsoluteScreenPixelRectangle GetWindowExtentsAbsolute() const override; - virtual tools::Rectangle GetWindowExtentsRelative(const vcl::Window& rRelativeWindow) const override; - virtual void GrabFocus() override; - virtual css::uno::Reference< css::accessibility::XAccessible > GetAccessible() override; - virtual vcl::Window* GetAccessibleParentWindow() const override; virtual vcl::Window* GetWindowInstance() override; virtual sal_Int32 GetAccessibleControlCount() const override; virtual bool ConvertPointToControlIndex( sal_Int32& _rnIndex, const Point& _rPoint ) override; diff --git a/toolkit/source/controls/table/tablecontrol.cxx b/toolkit/source/controls/table/tablecontrol.cxx index c5b5ef1c6b78..14cdd539f6f8 100644 --- a/toolkit/source/controls/table/tablecontrol.cxx +++ b/toolkit/source/controls/table/tablecontrol.cxx @@ -516,31 +516,6 @@ namespace svt::table m_pImpl->commitTableEvent( i_eventID, i_newValue, i_oldValue ); } - AbsoluteScreenPixelRectangle TableControl::GetWindowExtentsAbsolute() const - { - return Control::GetWindowExtentsAbsolute(); - } - - tools::Rectangle TableControl::GetWindowExtentsRelative(const vcl::Window& rRelativeWindow) const - { - return Control::GetWindowExtentsRelative( rRelativeWindow ); - } - - void TableControl::GrabFocus() - { - Control::GrabFocus(); - } - - Reference< XAccessible > TableControl::GetAccessible() - { - return Control::GetAccessible(); - } - - vcl::Window* TableControl::GetAccessibleParentWindow() const - { - return Control::GetAccessibleParentWindow(); - } - vcl::Window* TableControl::GetWindowInstance() { return this; commit b7a662e81432bc50ec485f6062cab4b0dc71870c Author: Michael Weghorn <m.wegh...@posteo.de> AuthorDate: Fri Jan 24 10:15:13 2025 +0100 Commit: Michael Weghorn <m.wegh...@posteo.de> CommitDate: Fri Jan 24 22:00:23 2025 +0100 Drop unused RowPos typedef The `RowPos` typedef used e.g. in toolkit/source/controls/table/tablecontrol_impl.cxx is defined the same way in toolkit/inc/controls/table/tabletypes.hxx . Change-Id: Ia9997150f1b9395bf4b7a73b079e0a79639b209e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180694 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> diff --git a/include/vcl/accessibletable.hxx b/include/vcl/accessibletable.hxx index 5afae8d1bfd1..e7d49b3935e9 100644 --- a/include/vcl/accessibletable.hxx +++ b/include/vcl/accessibletable.hxx @@ -30,8 +30,6 @@ namespace vcl { class Window; } namespace vcl::table { -typedef sal_Int32 RowPos; - enum class AccessibleTableControlObjType { GRIDCONTROL, /// The GridControl itself.