sw/source/core/undo/rolbck.cxx |   17 -----------------
 1 file changed, 17 deletions(-)

New commits:
commit cbec608e996c86c3242fe06ca3a42e9117072495
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed Jan 15 13:49:23 2025 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed Jan 15 14:20:12 2025 +0100

    remove dead code in SwRegHistory
    
    This was introduced in
    
        commit 7d9bb549d498d6beed2c4050c402d09643febdfa
        Author: Armin Le Grand <a...@apache.org>
        Date:   Mon Jun 2 15:00:50 2014 +0000
        Related: #i124638# Second step of DrawingLayer FillAttributes...
    
    But makes no sense because this pool item is really a hint, and it will
    be ignored in all the code paths that flow from here.
    
    Change-Id: I5e3aca9fa438c99f1883c8c56634264cd61e3eac
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/180273
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/sw/source/core/undo/rolbck.cxx b/sw/source/core/undo/rolbck.cxx
index 630a09796ce0..f35df80c09ae 100644
--- a/sw/source/core/undo/rolbck.cxx
+++ b/sw/source/core/undo/rolbck.cxx
@@ -1419,23 +1419,6 @@ void SwRegHistory::SwClientNotify(const SwModify&, const 
SfxHint& rHint)
         }
         return;
     }
-    if (rHint.GetId() != SfxHintId::SwLegacyModify)
-        return;
-    auto pLegacyHint = static_cast<const sw::LegacyModifyHint*>(&rHint);
-    if ( !(m_pHistory && pLegacyHint->m_pNew && 
!areSfxPoolItemPtrsEqual(pLegacyHint->m_pOld, pLegacyHint->m_pNew) ) )
-        return;
-
-    if ( pLegacyHint->m_pNew->Which() < POOLATTR_END )
-    {
-        if(RES_UPDATE_ATTR == pLegacyHint->m_pNew->Which())
-        {
-            m_pHistory->AddPoolItem(pLegacyHint->m_pOld, pLegacyHint->m_pNew, 
m_nNodeIndex);
-        }
-        else
-        {
-            OSL_ENSURE(false, "Unexpected update attribute (!)");
-        }
-    }
 }
 
 void SwRegHistory::AddHint( SwTextAttr* pHt, const bool bNew )

Reply via email to