Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1637440: API usage errors (INVALIDATE_ITERATOR)
/writerperfect/source/calc/MSWorksCalcImportFilter.cxx: 136 in
MSWorksCalcImportFilterInternal::<unnamed>::FolderStream::getSubStreamByName(const
char *)()
________________________________________________________________________________________________________
*** CID 1637440: API usage errors (INVALIDATE_ITERATOR)
/writerperfect/source/calc/MSWorksCalcImportFilter.cxx: 136 in
MSWorksCalcImportFilterInternal::<unnamed>::FolderStream::getSubStreamByName(const
char *)()
130 const uno::Reference<sdbc::XResultSet> xResultSet =
getResultSet(m_xContent);
131 if (xResultSet.is() && xResultSet->first())
132 {
133 const uno::Reference<ucb::XContentAccess>
xContentAccess(xResultSet,
134
uno::UNO_QUERY_THROW);
135 const uno::Reference<sdbc::XRow> xRow(xResultSet,
uno::UNO_QUERY_THROW);
>>> CID 1637440: API usage errors (INVALIDATE_ITERATOR)
>>> Dereferencing iterator
>>> "this->m_nameToPathMap.find(std::map<std::__cxx11::basic_string<char,
>>> std::char_traits<char>, std::allocator<char> >, rtl::OUString,
>>> std::less<std::__cxx11::basic_string<char, std::char_traits<char>,
>>> std::allocator<char> > >,
>>> std::allocator<std::pair<std::__cxx11::basic_string<char,
>>> std::char_traits<char>, std::allocator<char> > const, rtl::OUString> >
>>> >::key_type const(name, std::allocator<char>()))" though it is already past
>>> the end of its container.
136 OUString lPath = m_nameToPathMap.find(name)->second;
137 do
138 {
139 const OUString aTitle(xRow->getString(1));
140 if (aTitle != lPath)
141 continue;
** CID 1637439: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/tools/SlideshowLayerRenderer.cxx: 466 in
sd::SlideshowLayerRenderer::resolveEffect(const
std::shared_ptr<sd::CustomAnimationEffect> &)()
________________________________________________________________________________________________________
*** CID 1637439: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/tools/SlideshowLayerRenderer.cxx: 466 in
sd::SlideshowLayerRenderer::resolveEffect(const
std::shared_ptr<sd::CustomAnimationEffect> &)()
460 else
461 {
462 if (!aAnimationInfo.moObjectInfo)
463 aAnimationInfo.moObjectInfo = aLayerInfo;
464 }
465
>>> CID 1637439: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aAnimationInfo" is copied in a call to copy assignment "operator =",
>>> when it could be moved instead.
466 maRenderState.maAnimationRenderInfoList[pObject] = aAnimationInfo;
467 }
468
469 void SlideshowLayerRenderer::setupAnimations()
470 {
471 auto* pSdPage = dynamic_cast<SdPage*>(&mrPage);
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DNyZP_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtSuLeycFjOKuEAaDGbolDqE3dZiOTEw-2BulKaa5p6-2FYjIVt2ZIlXlS-2F6zwV8pWNrghO7iK8jBkbhRMn76Qp35pPPE-2FGCxQTQdD8G2haOkhOV-2BlDc8eMJDjkqOR4MWbHSTcrct3U30jGZKuwFKCpt8J7WJrmFak2scvZaPufIWanB8-3D