sw/source/ui/table/convert.cxx | 8 --------
sw/source/uibase/inc/convert.hxx | 8 --------
2 files changed, 16 deletions(-)
New commits:
commit 330eefb2b9aa29f2fcf5c7bb8005d2889c8190de
Author: Stephan Bergmann <stephan.bergm...@allotropia.de>
AuthorDate: Tue Dec 10 09:40:25 2024 +0100
Commit: Stephan Bergmann <stephan.bergm...@allotropia.de>
CommitDate: Tue Dec 10 11:24:12 2024 +0100
-Werror,-Wunused-private-field
Seemingly unused ever since the code was introduced in
1dd7cc9446233f047ace02f4275ef6405587b9c9 "tdf#116091: Replaced 'AutoFormat'
Button in Convert Text to Table dialog", but only reported by Clang 20 trunk
now, presumably since
<https://github.com/llvm/llvm-project/commit/d457100a8152cc2ebf8cd219caae92cc0f591156>
"[Clang] Fix -Wunused-private-field false negative with defaulted comparison
operators (#116871)".
Change-Id: I90fbd5be737b625f83283e8fbbb4d64d490d8fc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178201
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergm...@allotropia.de>
Reviewed-by: Heiko Tietze <heiko.tie...@documentfoundation.org>
diff --git a/sw/source/ui/table/convert.cxx b/sw/source/ui/table/convert.cxx
index 88fbe8c8d4a2..29f14394a810 100644
--- a/sw/source/ui/table/convert.cxx
+++ b/sw/source/ui/table/convert.cxx
@@ -92,13 +92,6 @@ void SwConvertTableDlg::GetValues(sal_Unicode& rDelim,
SwInsertTableOptions& rIn
SwConvertTableDlg::SwConvertTableDlg(SwView& rView, bool bToTable)
: SfxDialogController(rView.GetFrameWeld(),
u"modules/swriter/ui/converttexttable.ui"_ustr,
u"ConvertTextTableDialog"_ustr)
- , m_aStrTitle(SwResId(STR_ADD_AUTOFORMAT_TITLE))
- , m_aStrLabel(SwResId(STR_ADD_AUTOFORMAT_LABEL))
- , m_aStrClose(SwResId(STR_BTN_AUTOFORMAT_CLOSE))
- , m_aStrDelTitle(SwResId(STR_DEL_AUTOFORMAT_TITLE))
- , m_aStrDelMsg(SwResId(STR_DEL_AUTOFORMAT_MSG))
- , m_aStrRenameTitle(SwResId(STR_RENAME_AUTOFORMAT_TITLE))
- , m_aStrInvalidFormat(SwResId(STR_INVALID_AUTOFORMAT_NAME))
, m_nIndex(0)
, m_nDfltStylePos(0)
, m_bCoreDataChanged(false)
@@ -122,7 +115,6 @@ SwConvertTableDlg::SwConvertTableDlg(SwView& rView, bool
bToTable)
, m_xBtnPattern(m_xBuilder->weld_check_button(u"patterncb"_ustr))
, m_xBtnAlignment(m_xBuilder->weld_check_button(u"alignmentcb"_ustr))
, m_xWndPreview(new weld::CustomWeld(*m_xBuilder, u"preview"_ustr,
m_aWndPreview))
- , m_pShell(&rView.GetWrtShell())
{
m_aWndPreview.DetectRTL(&rView.GetWrtShell());
m_xTableTable->Load();
diff --git a/sw/source/uibase/inc/convert.hxx b/sw/source/uibase/inc/convert.hxx
index 8b976a948bf1..a0b83f823714 100644
--- a/sw/source/uibase/inc/convert.hxx
+++ b/sw/source/uibase/inc/convert.hxx
@@ -37,13 +37,6 @@ struct SwInsertTableOptions;
class SwConvertTableDlg final : public SfxDialogController
{
- OUString m_aStrTitle;
- OUString m_aStrLabel;
- OUString m_aStrClose;
- OUString m_aStrDelTitle;
- OUString m_aStrDelMsg;
- OUString m_aStrRenameTitle;
- OUString m_aStrInvalidFormat;
sal_uInt8 m_nIndex;
sal_uInt8 m_nDfltStylePos;
bool m_bCoreDataChanged : 1;
@@ -76,7 +69,6 @@ class SwConvertTableDlg final : public SfxDialogController
std::unique_ptr<weld::CheckButton> m_xBtnAlignment;
AutoFormatPreview m_aWndPreview;
std::unique_ptr<weld::CustomWeld> m_xWndPreview;
- SwWrtShell* m_pShell;
void Init();
void UpdateChecks(const SwTableAutoFormat&, bool bEnableBtn);
