Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.
13 new defect(s) introduced to LibreOffice found with Coverity Scan. 18 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 13 of 13 defect(s) ** CID 1636665: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636665: (UNINIT) /basic/source/uno/namecont.cxx: 3042 in basic::SfxLibrary::insertByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3036 3037 SAL_WARN_IF( 3038 !isLibraryElementValid(aElement), "basic", 3039 "SfxLibrary::insertByName: to-be-inserted element is invalid!"); 3040 3041 std::unique_lock guard(m_aMutex); >>> CID 1636665: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "insertByName". 3042 maNameContainer.insertByName(aName, aElement, guard); 3043 implSetModified(true, guard); 3044 } 3045 3046 void SfxLibrary::impl_removeWithoutChecks(const OUString& _rElementName, 3047 std::unique_lock<std::mutex>& guard) /basic/source/uno/namecont.cxx: 3042 in basic::SfxLibrary::insertByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3036 3037 SAL_WARN_IF( 3038 !isLibraryElementValid(aElement), "basic", 3039 "SfxLibrary::insertByName: to-be-inserted element is invalid!"); 3040 3041 std::unique_lock guard(m_aMutex); >>> CID 1636665: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "insertByName". 3042 maNameContainer.insertByName(aName, aElement, guard); 3043 implSetModified(true, guard); 3044 } 3045 3046 void SfxLibrary::impl_removeWithoutChecks(const OUString& _rElementName, 3047 std::unique_lock<std::mutex>& guard) /basic/source/uno/namecont.cxx: 3043 in basic::SfxLibrary::insertByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3037 SAL_WARN_IF( 3038 !isLibraryElementValid(aElement), "basic", 3039 "SfxLibrary::insertByName: to-be-inserted element is invalid!"); 3040 3041 std::unique_lock guard(m_aMutex); 3042 maNameContainer.insertByName(aName, aElement, guard); >>> CID 1636665: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 3043 implSetModified(true, guard); 3044 } 3045 3046 void SfxLibrary::impl_removeWithoutChecks(const OUString& _rElementName, 3047 std::unique_lock<std::mutex>& guard) 3048 { ** CID 1636664: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1636664: Null pointer dereferences (FORWARD_NULL) /sw/source/core/unocore/unostyle.cxx: 1158 in SwXStyleFamily::replaceByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 1152 { 1153 SwXStyle* pStyle = comphelper::getFromUnoTunnel<SwXStyle>(xStyle); 1154 if(pStyle) 1155 pStyle->Invalidate(); 1156 } 1157 m_pBasePool->Remove(pBase); >>> CID 1636664: Null pointer dereferences (FORWARD_NULL) >>> "insertByName" dereferences null "this->m_pDocShell". 1158 insertByName(rName, rElement); 1159 } 1160 } 1161 1162 void SwXStyleFamily::removeByName(const OUString& rName) 1163 { ** CID 1636663: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1636663: Uninitialized variables (UNINIT) /basic/source/uno/namecont.cxx: 2667 in basic::SfxLibraryContainer::addContainerListener(const com::sun::star::uno::Reference<com::sun::star::container::XContainerListener> &)() 2661 // Methods XContainer 2662 void SAL_CALL SfxLibraryContainer::addContainerListener( const Reference< XContainerListener >& xListener ) 2663 { 2664 LibraryContainerMethodGuard aGuard( *this ); 2665 std::unique_lock guard(m_aMutex); 2666 maNameContainer.setEventSource( getXWeak() ); >>> CID 1636663: Uninitialized variables (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "addContainerListener". 2667 maNameContainer.addContainerListener(xListener, guard); 2668 } 2669 2670 void SAL_CALL SfxLibraryContainer::removeContainerListener( const Reference< XContainerListener >& xListener ) 2671 { 2672 LibraryContainerMethodGuard aGuard( *this ); ** CID 1636662: (ATOMICITY) /basic/source/uno/namecont.cxx: 2197 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() /basic/source/uno/namecont.cxx: 2197 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1636662: (ATOMICITY) /basic/source/uno/namecont.cxx: 2197 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() 2191 if( mxStorage.is() ) 2192 { 2193 return; 2194 } 2195 if (pImplLib->hasElements()) 2196 { >>> CID 1636662: (ATOMICITY) >>> Using an unreliable value of "<anonymous>" inside the second locked >>> section. If the data that "<anonymous>" depends on was changed by another >>> thread, this use might be incorrect. 2197 for (auto& name : pImplLib->getElementNames()) 2198 pImplLib->impl_removeWithoutChecks(name, guard); 2199 } 2200 2201 // Delete index file 2202 createAppLibraryFolder(pImplLib.get(), Name); /basic/source/uno/namecont.cxx: 2197 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() 2191 if( mxStorage.is() ) 2192 { 2193 return; 2194 } 2195 if (pImplLib->hasElements()) 2196 { >>> CID 1636662: (ATOMICITY) >>> Using an unreliable value of "<anonymous>" inside the second locked >>> section. If the data that "<anonymous>" depends on was changed by another >>> thread, this use might be incorrect. 2197 for (auto& name : pImplLib->getElementNames()) 2198 pImplLib->impl_removeWithoutChecks(name, guard); 2199 } 2200 2201 // Delete index file 2202 createAppLibraryFolder(pImplLib.get(), Name); ** CID 1636661: Uninitialized variables (UNINIT) ________________________________________________________________________________________________________ *** CID 1636661: Uninitialized variables (UNINIT) /basic/source/uno/namecont.cxx: 2674 in basic::SfxLibraryContainer::removeContainerListener(const com::sun::star::uno::Reference<com::sun::star::container::XContainerListener> &)() 2668 } 2669 2670 void SAL_CALL SfxLibraryContainer::removeContainerListener( const Reference< XContainerListener >& xListener ) 2671 { 2672 LibraryContainerMethodGuard aGuard( *this ); 2673 std::unique_lock guard(m_aMutex); >>> CID 1636661: Uninitialized variables (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "removeContainerListener". 2674 maNameContainer.removeContainerListener(xListener, guard); 2675 } 2676 2677 // Methods XLibraryContainerExport 2678 void SAL_CALL SfxLibraryContainer::exportLibrary( const OUString& Name, const OUString& URL, 2679 const Reference< XInteractionHandler >& Handler ) ** CID 1636660: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636660: (UNINIT) /basic/source/uno/scriptcont.cxx: 399 in basic::SfxScriptLibraryContainer::verifyLibraryPassword(const rtl::OUString &, const rtl::OUString &)() 393 bSuccess = implLoadPasswordLibrary( pImplLib, Name, true, guard); 394 if( bSuccess ) 395 { 396 // The library gets modified by verifying the password, because other- 397 // wise for saving the storage would be copied and that doesn't work 398 // with mtg's storages when the password is verified >>> CID 1636660: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 399 pImplLib->implSetModified(true, guard); 400 pImplLib->mbPasswordVerified = true; 401 402 // Reload library to get source 403 if( pImplLib->mbLoaded ) 404 { /basic/source/uno/scriptcont.cxx: 399 in basic::SfxScriptLibraryContainer::verifyLibraryPassword(const rtl::OUString &, const rtl::OUString &)() 393 bSuccess = implLoadPasswordLibrary( pImplLib, Name, true, guard); 394 if( bSuccess ) 395 { 396 // The library gets modified by verifying the password, because other- 397 // wise for saving the storage would be copied and that doesn't work 398 // with mtg's storages when the password is verified >>> CID 1636660: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 399 pImplLib->implSetModified(true, guard); 400 pImplLib->mbPasswordVerified = true; 401 402 // Reload library to get source 403 if( pImplLib->mbLoaded ) 404 { ** CID 1636659: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636659: (UNINIT) /basic/source/uno/namecont.cxx: 2422 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2416 if( pImplLib->mbLink ) 2417 { 2418 if( pImplLib->mbReadOnlyLink != bool(bReadOnly) ) 2419 { 2420 pImplLib->mbReadOnlyLink = bReadOnly; 2421 pImplLib->implSetModified(true, guard); >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "setModified". 2422 maModifiable.setModified(true, guard); 2423 } 2424 } 2425 else 2426 { 2427 if( pImplLib->mbReadOnly != bool(bReadOnly) ) /basic/source/uno/namecont.cxx: 2430 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2424 } 2425 else 2426 { 2427 if( pImplLib->mbReadOnly != bool(bReadOnly) ) 2428 { 2429 pImplLib->mbReadOnly = bReadOnly; >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 2430 pImplLib->implSetModified(true, guard); 2431 } 2432 } 2433 } 2434 2435 void SAL_CALL SfxLibraryContainer::renameLibrary( const OUString& Name, const OUString& NewName ) /basic/source/uno/namecont.cxx: 2422 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2416 if( pImplLib->mbLink ) 2417 { 2418 if( pImplLib->mbReadOnlyLink != bool(bReadOnly) ) 2419 { 2420 pImplLib->mbReadOnlyLink = bReadOnly; 2421 pImplLib->implSetModified(true, guard); >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling "setModified". 2422 maModifiable.setModified(true, guard); 2423 } 2424 } 2425 else 2426 { 2427 if( pImplLib->mbReadOnly != bool(bReadOnly) ) /basic/source/uno/namecont.cxx: 2421 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2415 SfxLibrary* pImplLib = getImplLib( Name ); 2416 if( pImplLib->mbLink ) 2417 { 2418 if( pImplLib->mbReadOnlyLink != bool(bReadOnly) ) 2419 { 2420 pImplLib->mbReadOnlyLink = bReadOnly; >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 2421 pImplLib->implSetModified(true, guard); 2422 maModifiable.setModified(true, guard); 2423 } 2424 } 2425 else 2426 { /basic/source/uno/namecont.cxx: 2430 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2424 } 2425 else 2426 { 2427 if( pImplLib->mbReadOnly != bool(bReadOnly) ) 2428 { 2429 pImplLib->mbReadOnly = bReadOnly; >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 2430 pImplLib->implSetModified(true, guard); 2431 } 2432 } 2433 } 2434 2435 void SAL_CALL SfxLibraryContainer::renameLibrary( const OUString& Name, const OUString& NewName ) /basic/source/uno/namecont.cxx: 2421 in basic::SfxLibraryContainer::setLibraryReadOnly(const rtl::OUString &, unsigned char)() 2415 SfxLibrary* pImplLib = getImplLib( Name ); 2416 if( pImplLib->mbLink ) 2417 { 2418 if( pImplLib->mbReadOnlyLink != bool(bReadOnly) ) 2419 { 2420 pImplLib->mbReadOnlyLink = bReadOnly; >>> CID 1636659: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 2421 pImplLib->implSetModified(true, guard); 2422 maModifiable.setModified(true, guard); 2423 } 2424 } 2425 else 2426 { ** CID 1636658: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636658: (UNINIT) /basic/source/uno/namecont.cxx: 2184 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() 2178 rtl::Reference pImplLib(getImplLib(Name)); 2179 if( pImplLib->mbReadOnly && !pImplLib->mbLink ) 2180 { 2181 throw IllegalArgumentException(u"readonly && !link"_ustr, getXWeak(), 1); 2182 } 2183 // Remove from container >>> CID 1636658: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "removeByName". 2184 maNameContainer.removeByName(Name, guard); 2185 maModifiable.setModified(true, guard); 2186 2187 // Delete library files, but not for linked libraries 2188 if( pImplLib->mbLink ) 2189 return; /basic/source/uno/namecont.cxx: 2184 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() 2178 rtl::Reference pImplLib(getImplLib(Name)); 2179 if( pImplLib->mbReadOnly && !pImplLib->mbLink ) 2180 { 2181 throw IllegalArgumentException(u"readonly && !link"_ustr, getXWeak(), 1); 2182 } 2183 // Remove from container >>> CID 1636658: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "removeByName". 2184 maNameContainer.removeByName(Name, guard); 2185 maModifiable.setModified(true, guard); 2186 2187 // Delete library files, but not for linked libraries 2188 if( pImplLib->mbLink ) 2189 return; /basic/source/uno/namecont.cxx: 2185 in basic::SfxLibraryContainer::removeLibrary(const rtl::OUString &)() 2179 if( pImplLib->mbReadOnly && !pImplLib->mbLink ) 2180 { 2181 throw IllegalArgumentException(u"readonly && !link"_ustr, getXWeak(), 1); 2182 } 2183 // Remove from container 2184 maNameContainer.removeByName(Name, guard); >>> CID 1636658: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling "setModified". 2185 maModifiable.setModified(true, guard); 2186 2187 // Delete library files, but not for linked libraries 2188 if( pImplLib->mbLink ) 2189 return; 2190 ** CID 1636657: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636657: (UNINIT) /basic/source/uno/scriptcont.cxx: 490 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 484 { 485 pSL->mbLoadedSource = true; // must store source code now! 486 } 487 488 std::unique_lock guard(m_aMutex); 489 maModifiable.setModified(true, guard); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 490 pImplLib->implSetModified(true, guard); 491 492 if( !bStorage && !pImplLib->mbDoc50Password ) 493 { 494 // Store application basic crypted 495 uno::Reference< embed::XStorage > xStorage; /basic/source/uno/scriptcont.cxx: 463 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 457 { 458 pImplLib->mbPasswordProtected = false; 459 pImplLib->mbPasswordVerified = false; 460 pImplLib->maPassword.clear(); 461 462 std::unique_lock guard(m_aMutex); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling "setModified". 463 maModifiable.setModified(true, guard); 464 pImplLib->implSetModified(true, guard); 465 466 if( !bStorage && !pImplLib->mbDoc50Password ) 467 { 468 // Store application basic unencrypted /basic/source/uno/scriptcont.cxx: 463 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 457 { 458 pImplLib->mbPasswordProtected = false; 459 pImplLib->mbPasswordVerified = false; 460 pImplLib->maPassword.clear(); 461 462 std::unique_lock guard(m_aMutex); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "setModified". 463 maModifiable.setModified(true, guard); 464 pImplLib->implSetModified(true, guard); 465 466 if( !bStorage && !pImplLib->mbDoc50Password ) 467 { 468 // Store application basic unencrypted /basic/source/uno/scriptcont.cxx: 490 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 484 { 485 pSL->mbLoadedSource = true; // must store source code now! 486 } 487 488 std::unique_lock guard(m_aMutex); 489 maModifiable.setModified(true, guard); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 490 pImplLib->implSetModified(true, guard); 491 492 if( !bStorage && !pImplLib->mbDoc50Password ) 493 { 494 // Store application basic crypted 495 uno::Reference< embed::XStorage > xStorage; /basic/source/uno/scriptcont.cxx: 489 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 483 if (pSL && pSL->mbLoaded) 484 { 485 pSL->mbLoadedSource = true; // must store source code now! 486 } 487 488 std::unique_lock guard(m_aMutex); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "setModified". 489 maModifiable.setModified(true, guard); 490 pImplLib->implSetModified(true, guard); 491 492 if( !bStorage && !pImplLib->mbDoc50Password ) 493 { 494 // Store application basic crypted /basic/source/uno/scriptcont.cxx: 464 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 458 pImplLib->mbPasswordProtected = false; 459 pImplLib->mbPasswordVerified = false; 460 pImplLib->maPassword.clear(); 461 462 std::unique_lock guard(m_aMutex); 463 maModifiable.setModified(true, guard); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling >>> "implSetModified". 464 pImplLib->implSetModified(true, guard); 465 466 if( !bStorage && !pImplLib->mbDoc50Password ) 467 { 468 // Store application basic unencrypted 469 uno::Reference< embed::XStorage > xStorage; /basic/source/uno/scriptcont.cxx: 489 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 483 if (pSL && pSL->mbLoaded) 484 { 485 pSL->mbLoadedSource = true; // must store source code now! 486 } 487 488 std::unique_lock guard(m_aMutex); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling "setModified". 489 maModifiable.setModified(true, guard); 490 pImplLib->implSetModified(true, guard); 491 492 if( !bStorage && !pImplLib->mbDoc50Password ) 493 { 494 // Store application basic crypted /basic/source/uno/scriptcont.cxx: 464 in basic::SfxScriptLibraryContainer::changeLibraryPassword(const rtl::OUString &, const rtl::OUString &, const rtl::OUString &)() 458 pImplLib->mbPasswordProtected = false; 459 pImplLib->mbPasswordVerified = false; 460 pImplLib->maPassword.clear(); 461 462 std::unique_lock guard(m_aMutex); 463 maModifiable.setModified(true, guard); >>> CID 1636657: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 464 pImplLib->implSetModified(true, guard); 465 466 if( !bStorage && !pImplLib->mbDoc50Password ) 467 { 468 // Store application basic unencrypted 469 uno::Reference< embed::XStorage > xStorage; ** CID 1636656: (ATOMICITY) /basic/source/uno/namecont.cxx: 1059 in basic::SfxLibraryContainer::init_Impl(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, std::unique_lock<std::mutex> &)() /basic/source/uno/namecont.cxx: 1059 in basic::SfxLibraryContainer::init_Impl(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, std::unique_lock<std::mutex> &)() ________________________________________________________________________________________________________ *** CID 1636656: (ATOMICITY) /basic/source/uno/namecont.cxx: 1059 in basic::SfxLibraryContainer::init_Impl(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, std::unique_lock<std::mutex> &)() 1053 GbMigrationSuppressErrors = false; 1054 1055 // Rename folders back 1056 mxSFI->move( aFolderUserBasic, aPrevFolder ); 1057 mxSFI->move( aFolderTmp, aFolderUserBasic ); 1058 >>> CID 1636656: (ATOMICITY) >>> Using an unreliable value of "<anonymous>" inside the second locked >>> section. If the data that "<anonymous>" depends on was changed by another >>> thread, this use might be incorrect. 1059 for (auto& aLibName : pPrevCont->getElementNames()) 1060 { 1061 if( hasByName( aLibName ) ) 1062 { 1063 if( aLibName == aStandardStr ) 1064 { /basic/source/uno/namecont.cxx: 1059 in basic::SfxLibraryContainer::init_Impl(const rtl::OUString &, const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, std::unique_lock<std::mutex> &)() 1053 GbMigrationSuppressErrors = false; 1054 1055 // Rename folders back 1056 mxSFI->move( aFolderUserBasic, aPrevFolder ); 1057 mxSFI->move( aFolderTmp, aFolderUserBasic ); 1058 >>> CID 1636656: (ATOMICITY) >>> Using an unreliable value of "<anonymous>" inside the second locked >>> section. If the data that "<anonymous>" depends on was changed by another >>> thread, this use might be incorrect. 1059 for (auto& aLibName : pPrevCont->getElementNames()) 1060 { 1061 if( hasByName( aLibName ) ) 1062 { 1063 if( aLibName == aStandardStr ) 1064 { ** CID 1636655: (ATOMICITY) /basic/source/uno/namecont.cxx: 1903 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() /basic/source/uno/namecont.cxx: 1898 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() /basic/source/uno/namecont.cxx: 1903 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() /basic/source/uno/namecont.cxx: 1898 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() ________________________________________________________________________________________________________ *** CID 1636655: (ATOMICITY) /basic/source/uno/namecont.cxx: 1903 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() 1897 { 1898 implStorePasswordLibrary( pImplLib, rLib.aName, xLibraryStor, uno::Reference< task::XInteractionHandler >() ); 1899 // TODO: Check return value 1900 } 1901 else 1902 { >>> CID 1636655: (ATOMICITY) >>> Using an unreliable value of "pImplLib" inside the second locked >>> section. If the data that "pImplLib" depends on was changed by another >>> thread, this use might be incorrect. 1903 implStoreLibrary( pImplLib, rLib.aName, xLibraryStor ); 1904 } 1905 implStoreLibraryIndexFile( pImplLib, rLib, xLibraryStor ); 1906 if( bStorage ) 1907 { 1908 try /basic/source/uno/namecont.cxx: 1898 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() 1892 if( bComplete ) 1893 { 1894 loadLibrary_Impl(rLib.aName, guard); 1895 } 1896 if( pImplLib->mbPasswordProtected ) 1897 { >>> CID 1636655: (ATOMICITY) >>> Using an unreliable value of "pImplLib" inside the second locked >>> section. If the data that "pImplLib" depends on was changed by another >>> thread, this use might be incorrect. 1898 implStorePasswordLibrary( pImplLib, rLib.aName, xLibraryStor, uno::Reference< task::XInteractionHandler >() ); 1899 // TODO: Check return value 1900 } 1901 else 1902 { 1903 implStoreLibrary( pImplLib, rLib.aName, xLibraryStor ); /basic/source/uno/namecont.cxx: 1903 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() 1897 { 1898 implStorePasswordLibrary( pImplLib, rLib.aName, xLibraryStor, uno::Reference< task::XInteractionHandler >() ); 1899 // TODO: Check return value 1900 } 1901 else 1902 { >>> CID 1636655: (ATOMICITY) >>> Using an unreliable value of "pImplLib" inside the second locked >>> section. If the data that "pImplLib" depends on was changed by another >>> thread, this use might be incorrect. 1903 implStoreLibrary( pImplLib, rLib.aName, xLibraryStor ); 1904 } 1905 implStoreLibraryIndexFile( pImplLib, rLib, xLibraryStor ); 1906 if( bStorage ) 1907 { 1908 try /basic/source/uno/namecont.cxx: 1898 in basic::SfxLibraryContainer::storeLibraries_Impl(const com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &, bool, std::unique_lock<std::mutex> &)() 1892 if( bComplete ) 1893 { 1894 loadLibrary_Impl(rLib.aName, guard); 1895 } 1896 if( pImplLib->mbPasswordProtected ) 1897 { >>> CID 1636655: (ATOMICITY) >>> Using an unreliable value of "pImplLib" inside the second locked >>> section. If the data that "pImplLib" depends on was changed by another >>> thread, this use might be incorrect. 1898 implStorePasswordLibrary( pImplLib, rLib.aName, xLibraryStor, uno::Reference< task::XInteractionHandler >() ); 1899 // TODO: Check return value 1900 } 1901 else 1902 { 1903 implStoreLibrary( pImplLib, rLib.aName, xLibraryStor ); ** CID 1636654: Memory - illegal accesses (UNINIT) ________________________________________________________________________________________________________ *** CID 1636654: Memory - illegal accesses (UNINIT) /avmedia/source/framework/soundhandler.cxx: 253 in avmedia::SoundHandler::implts_PlayerNotify(Timer *)() 247 m_xListener->dispatchFinished(aEvent); 248 m_xListener.clear(); 249 } 250 251 // } SAFE 252 //release aLock before end of method at which point xOperationHold goes out of scope and pThis dies >>> CID 1636654: Memory - illegal accesses (UNINIT) >>> Using uninitialized value "aLock._M_owns" when calling "unlock". 253 aLock.unlock(); 254 } 255 256 } // namespace framework 257 258 ** CID 1636653: (UNINIT) ________________________________________________________________________________________________________ *** CID 1636653: (UNINIT) /basic/source/uno/namecont.cxx: 3026 in basic::SfxLibrary::replaceByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3020 3021 SAL_WARN_IF( 3022 !isLibraryElementValid(aElement), "basic", 3023 "SfxLibrary::replaceByName: replacing element is invalid!"); 3024 3025 std::unique_lock guard(m_aMutex); >>> CID 1636653: (UNINIT) >>> Using uninitialized value "guard._M_owns" when calling "replaceByName". 3026 maNameContainer.replaceByName(aName, aElement, guard); 3027 implSetModified(true, guard); 3028 } 3029 3030 3031 // Methods XNameContainer /basic/source/uno/namecont.cxx: 3026 in basic::SfxLibrary::replaceByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3020 3021 SAL_WARN_IF( 3022 !isLibraryElementValid(aElement), "basic", 3023 "SfxLibrary::replaceByName: replacing element is invalid!"); 3024 3025 std::unique_lock guard(m_aMutex); >>> CID 1636653: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "replaceByName". 3026 maNameContainer.replaceByName(aName, aElement, guard); 3027 implSetModified(true, guard); 3028 } 3029 3030 3031 // Methods XNameContainer /basic/source/uno/namecont.cxx: 3027 in basic::SfxLibrary::replaceByName(const rtl::OUString &, const com::sun::star::uno::Any &)() 3021 SAL_WARN_IF( 3022 !isLibraryElementValid(aElement), "basic", 3023 "SfxLibrary::replaceByName: replacing element is invalid!"); 3024 3025 std::unique_lock guard(m_aMutex); 3026 maNameContainer.replaceByName(aName, aElement, guard); >>> CID 1636653: (UNINIT) >>> Using uninitialized value "guard._M_device" when calling >>> "implSetModified". 3027 implSetModified(true, guard); 3028 } 3029 3030 3031 // Methods XNameContainer 3032 void SfxLibrary::insertByName( const OUString& aName, const Any& aElement ) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3Dh1ZI_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtbWW5Lwm-2B7L0HWa23hNXk48Yyk-2F-2ByVzhA9M0F-2FoiJVv3B3l7KK1qH5I8m0AKm55XAtjoBMp-2FiPGdzQUMJuCiqfznJkuC9EHBB33o5Yh-2FONO9k71z7-2BnNPeZFOvIjSKHUQbLQsdXHbTAo9UFQq2hDat4B2upO-2FKb8KCMO9B718J1I-3D