sw/source/core/text/frmcrsr.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 53110dd25ea16c34c1ead6ef3d58288003a865d2
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Tue Dec 3 22:58:02 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Dec 4 00:16:23 2024 +0100

    Revert "PVS: V614 Potentially null smart pointer 'pFillData' used"
    
    This reverts commit 60df7e1052e4ec0a33978df8af8afd65196dbd8c.
    
    Reason for revert:
    Michael Stahl: "the PVS warning is wrong, checking bChgFillData is already 
enough"
    
    Change-Id: I7d963e2b2ebbb30195af05b70ad36ab8d78e7c25
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177760
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sw/source/core/text/frmcrsr.cxx b/sw/source/core/text/frmcrsr.cxx
index df41204ecac8..a2545c300abf 100644
--- a/sw/source/core/text/frmcrsr.cxx
+++ b/sw/source/core/text/frmcrsr.cxx
@@ -637,12 +637,12 @@ bool 
SwTextFrame::GetModelPositionForViewPoint_(SwPosition* pPos, const Point& r
 
     if ( IsVertical() )
     {
-        if ( bChgFillData && pFillData )
+        if ( bChgFillData )
             SwitchHorizontalToVertical( pFillData->Fill().aCursor.Pos() );
         const_cast<SwTextFrame*>(this)->SwapWidthAndHeight();
     }
 
-    if ( IsRightToLeft() && bChgFillData && pFillData)
+    if ( IsRightToLeft() && bChgFillData )
     {
             SwitchLTRtoRTL( pFillData->Fill().aCursor.Pos() );
             const sal_Int16 eOrient = pFillData->pCMS->m_pFill->eOrient;

Reply via email to