core.git: Branch 'libreoffice-24-8' - sw/source

[Szymon Kłos (via logerrit)]

 sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 058f0d1cac5d9e5d109dc7fe360bf03f8e1facc1
Author:     Szymon Kłos <szymon.k...@collabora.com>
AuthorDate: Mon Nov 25 15:15:36 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Tue Nov 26 10:16:36 2024 +0100

    tdf#86731 bNoDictionaryAvailable should trigger meesagebox
    
    Reverts "PVS: V547 Expression 'bNoDictionaryAvailable' is always false"
    This reverts commit 816b51c7a9cdd72eaa01f3c074ba5a8446917d19.
    
    It removed the message completely from the code while, we should
    fix it rather by using correct condition.
    
    It was somehow too aggresively limited in commit 
f200dd5cb84681558700c49de0969907f78f8db1
    tdf#86731 Don't show 'start from beginning' when dictionary is missing
    
    Change-Id: I5f4b859047216399a09c7aefb8a47244c4833df5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177271
    (cherry picked from commit 16bce5bb1cb4e446f45633b128f6ab02a48b6840)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177316
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
    Reviewed-by: Szymon Kłos <szymon.k...@collabora.com>
    Tested-by: Jenkins

diff --git a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx 
b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
index 6a865078af74..9f91675381b2 100644
--- a/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
+++ b/sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx
@@ -398,7 +398,7 @@ The code below would only be part of the solution.
                     bCloseMessage = false; // no closing message if a wrap 
around has been denied
             }
         }
-        if( aRet.empty() && bCloseMessage && !bNoDictionaryAvailable )
+        if( aRet.empty() && bCloseMessage )
         {
             LockFocusNotification( true );
             OUString sInfo( SwResId( bNoDictionaryAvailable ? 
STR_DICTIONARY_UNAVAILABLE : STR_SPELLING_COMPLETED ) );