sc/source/ui/view/tabvwshf.cxx |   10 ----------
 1 file changed, 10 deletions(-)
New commits:
commit fbfa2769f261cba11a5ea7f3be648fa67c3816ca
Author:     Aron Budea <aron.bu...@collabora.com>
AuthorDate: Mon Nov 25 00:06:29 2024 +1030
Commit:     Aron Budea <aron.bu...@collabora.com>
CommitDate: Mon Nov 25 06:49:03 2024 +0100

    tdf#163486 PVS V1037 Two or more case-branches perform the same actions
    
    second identical branch was added in
    d519cbe89268ff24e2b8b05ba5124dca98f22b79
    
    and
    V530 The return value of function 'GetTitle' is required...
    to be utilized
    
    the unnecessary GetTitle() call that was duplicated in
    d519cbe89268ff24e2b8b05ba5124dca98f22b79 was there since
    9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 (initial import)
    
    Change-Id: Ied25faf177184cc1b1ca4a512285232bf966c1e4
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177209
    Reviewed-by: Mike Kaganski <mike.kagan...@collabora.com>
    Tested-by: Jenkins
    Reviewed-by: Aron Budea <aron.bu...@collabora.com>

diff --git a/sc/source/ui/view/tabvwshf.cxx b/sc/source/ui/view/tabvwshf.cxx
index 8c0d4049ffc4..70b9e424c32f 100644
--- a/sc/source/ui/view/tabvwshf.cxx
+++ b/sc/source/ui/view/tabvwshf.cxx
@@ -227,8 +227,6 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
 
                     if( pScSh )
                     {
-                        pScSh->GetTitle();
-
                         if (aDocName == pScSh->GetTitle(SFX_TITLE_FULLNAME))
                         {
                             nDoc = i;
@@ -540,12 +538,6 @@ void ScTabViewShell::GetStateTable( SfxItemSet& rSet )
                 break;
 
             case FID_TAB_MOVE:
-                if (   !rDoc.IsDocEditable()
-                    || rDoc.GetChangeTrack() != nullptr
-                    || nTabCount > MAXTAB)
-                    rSet.DisableItem( nWhich );
-                break;
-
             case FID_TAB_DUPLICATE:
                 if (   !rDoc.IsDocEditable()
                     || rDoc.GetChangeTrack() != nullptr
@@ -763,8 +755,6 @@ void ScTabViewShell::ExecuteMoveTable( SfxRequest& rReq )
 
                     if( pScSh )
                     {
-                        pScSh->GetTitle();
-
                         if (aDocName == pScSh->GetTitle())
                         {
                             nDoc = i;

Reply via email to