vcl/source/gdi/pdfwriter_impl.cxx | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
New commits:
commit 510467f5b2b9b9dc5ba0cd24b446dcd2c2e32acf
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Nov 21 12:27:22 2024 +0100
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Thu Nov 21 15:55:19 2024 +0100
tdf#163486: PVS: variable was assigned the same value
Since
commit 1a1e953ee33c213dc8b88dd96a69ca9fc5e42d50
Author: Gökçen Eraslan <gokcen.eras...@gmail.com>
Date: Mon Jul 9 13:53:38 2012 +0300
We use hidden signatures for now.
V1048 The 'sigHidden' variable was assigned the same value.
Change-Id: If394032db0cc848864a640e45a0492eee28b5205
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176917
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx
b/vcl/source/gdi/pdfwriter_impl.cxx
index 5adb2e53358a..9ce671e05f47 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -11874,7 +11874,6 @@ sal_Int32 PDFWriterImpl::createControl( const
PDFWriter::AnyWidget& rControl, sa
if( nPageNr < 0 || o3tl::make_unsigned(nPageNr) >= m_aPages.size() )
return -1;
- bool sigHidden(true);
sal_Int32 nNewWidget = m_aWidgets.size();
m_aWidgets.emplace_back( );
@@ -12047,8 +12046,6 @@ sal_Int32 PDFWriterImpl::createControl( const
PDFWriter::AnyWidget& rControl, sa
#if HAVE_FEATURE_NSS
else if( rControl.getType() == PDFWriter::Signature)
{
- sigHidden = true;
-
rNewWidget.m_aRect = tools::Rectangle(0, 0, 0, 0);
m_nSignatureObject = createObject();
@@ -12059,9 +12056,9 @@ sal_Int32 PDFWriterImpl::createControl( const
PDFWriter::AnyWidget& rControl, sa
}
#endif
- // if control is a hidden signature, do not convert coordinates since we
+ // if control is a signature, do not convert coordinates since we
// need /Rect [ 0 0 0 0 ]
- if ( ! ( ( rControl.getType() == PDFWriter::Signature ) && sigHidden ) )
+ if ( rControl.getType() != PDFWriter::Signature )
{
// convert to default user space now, since the mapmode may change
// note: create default appearances before m_aRect gets transformed
