desktop/source/offacc/acceptor.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit ed8514af4930fdf67f0f213f62551dbbec45af83
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Mon Nov 11 10:49:14 2024 +0000
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Sun Nov 17 15:41:46 2024 +0100

    cid#1607905 Data race condition
    
    Change-Id: Idb525a4e19cfbe0c4a493f511be7dadafac0cff5
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176465
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
    Tested-by: Jenkins

diff --git a/desktop/source/offacc/acceptor.cxx 
b/desktop/source/offacc/acceptor.cxx
index 5dbecd0f1254..2c51a73c1199 100644
--- a/desktop/source/offacc/acceptor.cxx
+++ b/desktop/source/offacc/acceptor.cxx
@@ -117,10 +117,9 @@ void Acceptor::run()
             // create the bridge. The remote end will have a reference to this 
bridge
             // thus preventing the bridge from being disposed. When the remote 
end releases
             // the bridge, it will be destructed.
-            Reference< XBridge > rBridge = m_rBridgeFactory->createBridge(
-                u""_ustr, m_aProtocol, rConnection, rInstanceProvider);
             std::unique_lock g(m_aMutex);
-            m_bridges.add(rBridge);
+            m_bridges.add(m_rBridgeFactory->createBridge(
+                u""_ustr, m_aProtocol, rConnection, rInstanceProvider));
         } catch (const Exception&) {
             TOOLS_WARN_EXCEPTION("desktop.offacc", "");
             // connection failed...

Reply via email to