chart2/source/controller/dialogs/ChartResourceGroups.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit adcc06a4564164b8b0a73ce4254d54f144675bc9
Author:     Bogdan Buzea <buzea.bog...@libreoffice.org>
AuthorDate: Fri Oct 18 17:06:12 2024 +0200
Commit:     David Gilbert <freedesk...@treblig.org>
CommitDate: Sat Nov 16 15:17:55 2024 +0100

    tdf#163486: PVS: Identical branches
    
    V1037 Two or more case-branches perform the same actions. Check lines: 146, 
158. This will still be the case, the code being just at the moment similar.
    
    Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146
    Reviewed-by: David Gilbert <freedesk...@treblig.org>
    Tested-by: Jenkins

diff --git a/chart2/source/controller/dialogs/ChartResourceGroups.cxx 
b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
index 1e43eb481a36..f773eefd7062 100644
--- a/chart2/source/controller/dialogs/ChartResourceGroups.cxx
+++ b/chart2/source/controller/dialogs/ChartResourceGroups.cxx
@@ -142,9 +142,6 @@ void StackingResourceGroup::fillControls(const 
ChartTypeParameter& rParameter)
                != GlobalStackMode_STACK_Z); //todo remove this condition if z 
stacking radio button is really used
     switch (rParameter.eStackMode)
     {
-        case GlobalStackMode_STACK_Y:
-            m_xRB_Stack_Y->set_active(true);
-            break;
         case GlobalStackMode_STACK_Y_PERCENT:
             m_xRB_Stack_Y_Percent->set_active(true);
             break;
@@ -157,6 +154,7 @@ void StackingResourceGroup::fillControls(const 
ChartTypeParameter& rParameter)
             */
             m_xRB_Stack_Y->set_active(true);
             break;
+        case GlobalStackMode_STACK_Y:
         default:
             m_xRB_Stack_Y->set_active(true);
             break;

Reply via email to