core.git: sw/source

[Xisco Fauli (via logerrit)]

 sw/source/ui/frmdlg/frmpage.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d03f1ed446731f343dc594fc29366ed120b1d5ff
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Nov 14 11:49:14 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Thu Nov 14 14:18:30 2024 +0100

    tdf#163486: PVS: Expression is always true
    
    V560    A part of conditional expression is always true: pFlyFormat.
    
    Change-Id: I9cc68a314dcdf98857eaf39aacf613d6fa67b720
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176584
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sw/source/ui/frmdlg/frmpage.cxx b/sw/source/ui/frmdlg/frmpage.cxx
index 4b530ab8ce05..5de4a804bbf0 100644
--- a/sw/source/ui/frmdlg/frmpage.cxx
+++ b/sw/source/ui/frmdlg/frmpage.cxx
@@ -1107,7 +1107,7 @@ void SwFramePage::Reset( const SfxItemSet *rSet )
             m_xFlySplitCB->hide();
         }
     }
-    else if (pFlyFormat && !m_bNew && InTextBox(*pFlyFormat))
+    else if (!m_bNew && InTextBox(*pFlyFormat))
     {
         // Disallow split flys in fly frames which form a textbox, i.e. 
non-editeng shape text.
         m_xFlySplitCB->hide();