core.git: sfx2/source

[Xisco Fauli (via logerrit)]

 sfx2/source/control/thumbnailview.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9b3159b984f703345306fbf9dadb433f806505e5
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Nov 14 11:34:16 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Thu Nov 14 12:59:57 2024 +0100

    tdf#163486: PVS: Expression is always true
    
    V560    A part of conditional expression is always true: pItem->mbVisible.
    
    Change-Id: Id9c55e610fa81003a5ad7661d98962aa6d48c062
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176579
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sfx2/source/control/thumbnailview.cxx 
b/sfx2/source/control/thumbnailview.cxx
index 0f573670412b..261ee64d6ec3 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -201,7 +201,7 @@ OUString ThumbnailView::RequestHelp(tools::Rectangle& 
rHelpRect)
         if (!pItem->mbVisible)
             continue;
         const tools::Rectangle& rDrawArea = pItem->getDrawArea();
-        if (pItem->mbVisible && rDrawArea.Contains(aPos))
+        if (rDrawArea.Contains(aPos))
         {
             rHelpRect = rDrawArea;
             return pItem->getHelpText();