core.git: 2 commits - svtools/source sw/source

[Xisco Fauli (via logerrit)]

 svtools/source/brwbox/brwbox1.cxx |    2 +-
 sw/source/filter/ww8/ww8par5.cxx  |    4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 5621b4b488abb4283c09f6f08b4c0e62dc6cd6a4
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Nov 13 11:02:55 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Nov 13 12:50:43 2024 +0100

    tdf#163486: PVS: Expression can be simplified
    
    Since
    commit 8ab086b6cc054501bfbf7ef6fa509c393691e860
    Author: Jens-Heiner Rechtien <h...@openoffice.org>
    Date:   Mon Sep 18 16:07:07 2000 +0000
    
        initial import
    
    V1065   Expression can be simplified, check 'nRowCount' and similar 
operands.
    
    Change-Id: Icd9cdd82cb083e2b40498a21de44a814169977ef
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176524
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/svtools/source/brwbox/brwbox1.cxx 
b/svtools/source/brwbox/brwbox1.cxx
index 841a96d7af7e..0863dd9870c7 100644
--- a/svtools/source/brwbox/brwbox1.cxx
+++ b/svtools/source/brwbox/brwbox1.cxx
@@ -2260,7 +2260,7 @@ void BrowseBox::VisibleRowsChanged( sal_Int32, sal_uInt16 
)
     }
     else if ( nRowCount > GetRowCount() )
     {
-        RowRemoved(nRowCount-(nRowCount - GetRowCount()),nRowCount - 
GetRowCount(), false);
+        RowRemoved(GetRowCount(), nRowCount - GetRowCount(), false);
     }
 }
 
commit 4444d134150209f8c49e8b2d3f5347a51f7b9b04
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Wed Nov 13 10:28:37 2024 +0100
Commit:     Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Wed Nov 13 12:50:31 2024 +0100

    tdf#163486: PVS: variable is assigned but not used
    
    Since
    commit c617be8307033394bde4255c05b72dbd01ae0056
    Author: Norbert Thiebaud <nthieb...@gmail.com>
    Date:   Tue Nov 27 22:58:50 2012 -0600
    
        remove legacy String svl's Put*Entry family of function and convert 
users
    
    V1001   The 'sParams' variable is assigned but is not used by the end of 
the function.
    
    Change-Id: I90e32de620be23b22c4ab4ee4973433455d844b1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176522
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>

diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index c845941ad324..8f2a12984e9e 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -475,10 +475,8 @@ SvNumFormatType 
SwWW8ImplReader::GetTimeDatePara(std::u16string_view aStr, sal_u
         SvNumFormatType nType = SvNumFormatType::DEFINED;
         rFormat = 0;
 
-        OUString sTemp(sParams);
-        pFormatter->PutandConvertEntry(sTemp, nCheckPos, nType, rFormat,
+        pFormatter->PutandConvertEntry(sParams, nCheckPos, nType, rFormat,
                                        LANGUAGE_ENGLISH_US, rLang, false);
-        sParams = sTemp;
 
         return bHasTime ? SvNumFormatType::DATETIME : SvNumFormatType::DATE;
     }