sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
New commits: commit 753be8826eb21d105821b30f2b55a993a2df14f4 Author: Bogdan Buzea <buzea.bog...@libreoffice.org> AuthorDate: Sat Oct 19 18:12:16 2024 +0200 Commit: David Gilbert <freedesk...@treblig.org> CommitDate: Tue Nov 12 02:05:19 2024 +0100 tdf#163486: PVS: Identical branches V1037 Two or more case-branches perform the same actions. Check lines: 981, 1008 V1037 Two or more case-branches perform the same actions. Check lines: 1018, 1025 Change-Id: Iea6f6edc65490587cb974f6d3baa17d3a337a0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175217 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesk...@treblig.org> diff --git a/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx b/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx index 24f62aa23090..af09253db8d1 100644 --- a/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx +++ b/sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx @@ -977,10 +977,6 @@ bool NormalModeHandler::ProcessButtonDownEvent ( switch (rDescriptor.mnEventCode) { - case BUTTON_DOWN | LEFT_BUTTON | SINGLE_CLICK | OVER_UNSELECTED_PAGE: - SetCurrentPage(rDescriptor.mpHitDescriptor); - break; - case BUTTON_DOWN | LEFT_BUTTON | SINGLE_CLICK | OVER_SELECTED_PAGE: break; @@ -999,6 +995,7 @@ bool NormalModeHandler::ProcessButtonDownEvent ( break; // Right button for context menu. + case BUTTON_DOWN | LEFT_BUTTON | SINGLE_CLICK | OVER_UNSELECTED_PAGE: case BUTTON_DOWN | RIGHT_BUTTON | SINGLE_CLICK | OVER_UNSELECTED_PAGE: // Single right click and shift+F10 select as preparation to // show the context menu. Change the selection only when the @@ -1013,12 +1010,6 @@ bool NormalModeHandler::ProcessButtonDownEvent ( break; case BUTTON_DOWN | RIGHT_BUTTON | SINGLE_CLICK | NOT_OVER_PAGE: - // Remember the current selection so that when a multi selection - // is started, we can restore the previous selection. - mrSlideSorter.GetModel().SaveCurrentSelection(); - DeselectAllPages(); - break; - case ANY_MODIFIER(BUTTON_DOWN | LEFT_BUTTON | SINGLE_CLICK | NOT_OVER_PAGE): // Remember the current selection so that when a multi selection // is started, we can restore the previous selection.