core.git: filter/source

[Noel Grandin (via logerrit)]

 filter/source/msfilter/escherex.cxx              |    2 +-
 filter/source/msfilter/msdffimp.cxx              |    2 +-
 filter/source/xsltdialog/xmlfiltertestdialog.cxx |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ff1a24de3ce9e052732bc4816e026c5725de5509
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Nov 11 19:32:28 2024 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Nov 11 20:11:34 2024 +0100

    clang-tidy: performance-unnecessary-copy-initialization in filter
    
    Change-Id: I20d340f2093534424a5a81b84135326271563aa7
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176414
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
    Tested-by: Jenkins

diff --git a/filter/source/msfilter/escherex.cxx 
b/filter/source/msfilter/escherex.cxx
index c0b854d5de48..1fbba9923dc2 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -1927,7 +1927,7 @@ bool EscherPropertyContainer::CreatePolygonProperties(
 
     for(sal_uInt16 j(0); j < nPolyCount; ++j)
     {
-        const tools::Polygon aPolygon(aPolyPolygon[j]);
+        const tools::Polygon& aPolygon(aPolyPolygon[j]);
         const sal_uInt16 nPoints(aPolygon.GetSize());
 
         if(0 == nPoints)
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 9e93a6f84df6..c1b5ada846e4 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -5936,7 +5936,7 @@ void SvxMSDffManager::CheckTxBxStoryChain()
             mark = m_xShapeInfosByTxBxComp->begin();
          iter != m_xShapeInfosByTxBxComp->end(); ++iter)
     {
-        std::shared_ptr<SvxMSDffShapeInfo> const pObj = *iter;
+        std::shared_ptr<SvxMSDffShapeInfo> const& pObj = *iter;
         if( pObj->nTxBxComp )
         {
             // group change?
diff --git a/filter/source/xsltdialog/xmlfiltertestdialog.cxx 
b/filter/source/xsltdialog/xmlfiltertestdialog.cxx
index edf07421e956..616fc65c759e 100644
--- a/filter/source/xsltdialog/xmlfiltertestdialog.cxx
+++ b/filter/source/xsltdialog/xmlfiltertestdialog.cxx
@@ -574,7 +574,7 @@ void XMLFilterTestDialog::import( const OUString& rURL )
         if( m_xCBXDisplaySource->get_active() )
         {
             TempFileNamed aTempFile(u"", true, u".xml");
-            OUString aTempFileURL( aTempFile.GetURL() );
+            const OUString& aTempFileURL( aTempFile.GetURL() );
 
             Reference< XImportFilter > xImporter( 
mxContext->getServiceManager()->createInstanceWithContext( 
u"com.sun.star.documentconversion.XSLTFilter"_ustr, mxContext ), UNO_QUERY );
             if( xImporter.is() )